Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux PTB version-name shows TOLOWER #7220

Closed
vadi2 opened this issue May 12, 2024 · 0 comments · Fixed by #7221
Closed

Linux PTB version-name shows TOLOWER #7220

vadi2 opened this issue May 12, 2024 · 0 comments · Fixed by #7221
Assignees

Comments

@vadi2
Copy link
Member

vadi2 commented May 12, 2024

Brief summary of issue / Description of requested feature:

The version of the latest Linux PTB is Mudlet 4.17.2-ptb-2024-05-10-string;(;TOLOWER;6d7c931e;) which is not correct.

image

@Kebap Kebap changed the title Linux PTB version is broken Linux PTB version-name shows TOLOWER May 12, 2024
@SlySven SlySven self-assigned this May 12, 2024
SlySven added a commit to SlySven/Mudlet that referenced this issue May 12, 2024
#### Brief overview of PR changes/additions
I made an error in Mudlet#7160 as I thought that something that looked like a
function call returned a value that could be assigned to something with a
`set(...)` but CMake doesn't work like that, instead one has to provide a
variable to recieve the value as the last argument to a `string(...)`
function. 🙄

#### Motivation for adding to Mudlet
Fix an error that causes cruft to appear, at least, in the version number
on the first tab of the "About Mudlet" dialogue.

#### Other info (issues closed, discussion etc)
This should close Mudlet#7220.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven added a commit that referenced this issue May 12, 2024
#### Brief overview of PR changes/additions
I made an error in #7160 as I thought that something that looked like a
function call returned a value that could be assigned to something with
a `set(...)` but CMake doesn't work like that, instead one has to
provide a variable to recieve the value as the last argument to a
`string(...)` function. 🙄

#### Motivation for adding to Mudlet
Fix an error that causes cruft to appear, at least, in the version
number on the first tab of the "About Mudlet" dialogue.

#### Other info (issues closed, discussion etc)
This should close #7220.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants