Merge pull request #44 from discordier/hotfix/return-types

Return `this` in `.start()` and `.update()`
Mugen87 · May 3, 2021 · 90d7439 · 90d7439
2 parents 6314fd6 + 2a5dcc6
commit 90d7439
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/core/GameEntity.js b/src/core/GameEntity.js
@@ -204,7 +204,11 @@ class GameEntity {
 	*
 	* @return {GameEntity} A reference to this game entity.
 	*/
-	start() {}
+	start() {
+
+		return this;
+
+	}
 
 	/**
 	* Updates the internal state of this game entity. Normally called by {@link EntityManager#update}
@@ -213,7 +217,11 @@ class GameEntity {
 	* @param {Number} delta - The time delta.
 	* @return {GameEntity} A reference to this game entity.
 	*/
-	update( /* delta */ ) {}
+	update( /* delta */ ) {
+
+		return this;
+
+	}
 
 
 	/**

diff --git a/test/unit_test/core/GameEntity.tests.js b/test/unit_test/core/GameEntity.tests.js
@@ -65,6 +65,13 @@ describe( 'GameEntity', function () {
 
 		} );
 
+		it( 'should return self', function () {
+
+			const entity = new GameEntity();
+			expect( entity.start() ).to.equal( entity );
+
+		} );
+
 	} );
 
 	describe( '#update()', function () {
@@ -76,6 +83,13 @@ describe( 'GameEntity', function () {
 
 		} );
 
+		it( 'should return self', function () {
+
+			const entity = new GameEntity();
+			expect( entity.update() ).to.equal( entity );
+
+		} );
+
 	} );
 
 	describe( '#add()', function () {