Skip to content

Commit

Permalink
For mozilla-mobile#26826 - Add test tags for the Pocket section
Browse files Browse the repository at this point in the history
  • Loading branch information
@Mugurell
Mugurell committed Nov 8, 2022
1 parent 39937f5 commit 7ea1bd1
Showing 1 changed file with 71 additions and 10 deletions.
81 changes: 71 additions & 10 deletions app/src/main/java/org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.ExperimentalComposeUiApi
import androidx.compose.ui.Modifier
import androidx.compose.ui.composed
import androidx.compose.ui.graphics.Color
Expand All @@ -44,6 +45,8 @@ import androidx.compose.ui.platform.LocalView
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTag
import androidx.compose.ui.semantics.testTagsAsResourceId
import androidx.compose.ui.text.style.TextDecoration
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.Preview
Expand Down Expand Up @@ -101,6 +104,7 @@ private val placeholderStory = PocketRecommendedStory("", "", "", "", "", 0, 0)
* @param backgroundColor The background [Color] of the story.
* @param onStoryClick Callback for when the user taps on this story.
*/
@OptIn(ExperimentalComposeUiApi::class)
@Composable
fun PocketStory(
@PreviewParameter(PocketStoryProvider::class) story: PocketRecommendedStory,
Expand All @@ -120,6 +124,10 @@ fun PocketStory(
title = {
Text(
text = story.title,
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.story.title"
},
color = FirefoxTheme.colors.textPrimary,
overflow = TextOverflow.Ellipsis,
maxLines = 2,
Expand All @@ -132,6 +140,10 @@ fun PocketStory(
} else if (isValidPublisher) {
Text(
text = story.publisher,
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.story.publisher"
},
color = FirefoxTheme.colors.textSecondary,
overflow = TextOverflow.Ellipsis,
maxLines = 1,
Expand All @@ -140,6 +152,10 @@ fun PocketStory(
} else if (isValidTimeToRead) {
Text(
text = "${story.timeToRead} min",
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.story.timeToRead"
},
color = FirefoxTheme.colors.textSecondary,
overflow = TextOverflow.Ellipsis,
maxLines = 1,
Expand All @@ -157,6 +173,7 @@ fun PocketStory(
* @param backgroundColor The background [Color] of the story.
* @param onStoryClick Callback for when the user taps on this story.
*/
@OptIn(ExperimentalComposeUiApi::class)
@Composable
fun PocketSponsoredStory(
story: PocketSponsoredStory,
Expand All @@ -178,6 +195,10 @@ fun PocketSponsoredStory(
) {
Text(
text = story.title,
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.sponsoredStory.title"
},
color = FirefoxTheme.colors.textPrimary,
overflow = TextOverflow.Ellipsis,
maxLines = 2,
Expand All @@ -188,6 +209,10 @@ fun PocketSponsoredStory(

Text(
text = stringResource(R.string.pocket_stories_sponsor_indication),
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.sponsoredStory.identifier"
},
color = FirefoxTheme.colors.textSecondary,
overflow = TextOverflow.Ellipsis,
maxLines = 1,
Expand All @@ -198,6 +223,10 @@ fun PocketSponsoredStory(

Text(
text = story.sponsor,
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.sponsoredStory.sponsor"
},
color = FirefoxTheme.colors.textSecondary,
overflow = TextOverflow.Ellipsis,
maxLines = 1,
Expand All @@ -219,6 +248,7 @@ fun PocketSponsoredStory(
* @param onStoryClicked Callback for when the user taps on a recommended story.
* @param onDiscoverMoreClicked Callback for when the user taps an element which contains an
*/
@OptIn(ExperimentalComposeUiApi::class)
@Suppress("LongParameterList")
@Composable
fun PocketStories(
Expand All @@ -237,6 +267,10 @@ fun PocketStories(
val flingBehavior = EagerFlingBehavior(lazyRowState = listState)

LazyRow(
modifier = Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.stories"
},
contentPadding = PaddingValues(horizontal = contentPadding),
state = listState,
flingBehavior = flingBehavior,
Expand Down Expand Up @@ -381,6 +415,7 @@ private fun Rect.getIntersectPercentage(realSize: IntSize, other: Rect): Float {
* @param onCategoryClick Callback for when the user taps a category.
* @param modifier [Modifier] to be applied to the layout.
*/
@OptIn(ExperimentalComposeUiApi::class)
@Suppress("LongParameterList")
@Composable
fun PocketStoriesCategories(
Expand All @@ -393,7 +428,14 @@ fun PocketStoriesCategories(
onCategoryClick: (PocketRecommendedStoriesCategory) -> Unit,
modifier: Modifier = Modifier,
) {
Box(modifier = modifier) {
Box(
modifier = modifier.then(
Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.categories"
},
),
) {
StaggeredHorizontalGrid(
horizontalItemsSpacing = 16.dp,
verticalItemsSpacing = 16.dp,
Expand Down Expand Up @@ -424,6 +466,7 @@ fun PocketStoriesCategories(
* @param textColor [Color] to be applied to the text.
* @param linkTextColor [Color] of the link text.
*/
@OptIn(ExperimentalComposeUiApi::class)
@Composable
fun PoweredByPocketHeader(
onLearnMoreClicked: (String) -> Unit,
Expand All @@ -437,7 +480,10 @@ fun PoweredByPocketHeader(
val linkEndIndex = linkStartIndex + link.length

Column(
modifier = modifier,
modifier = modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.header"
},
horizontalAlignment = Alignment.CenterHorizontally,
) {
Row(
Expand All @@ -461,19 +507,34 @@ fun PoweredByPocketHeader(
R.string.pocket_stories_feature_title_2,
LocalContext.current.getString(R.string.pocket_product_name),
),
Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.header.title"
},
color = textColor,
style = FirefoxTheme.typography.caption,
)

ClickableSubstringLink(
text = text,
textColor = textColor,
linkTextColor = linkTextColor,
linkTextDecoration = TextDecoration.Underline,
clickableStartIndex = linkStartIndex,
clickableEndIndex = linkEndIndex,
Box(
modifier = modifier.then(
Modifier.semantics {
testTagsAsResourceId = true
testTag = "pocket.header.subtitle"
},
),
) {
onLearnMoreClicked("https://www.mozilla.org/en-US/firefox/pocket/?$POCKET_FEATURE_UTM_KEY_VALUE")
ClickableSubstringLink(
text = text,
textColor = textColor,
linkTextColor = linkTextColor,
linkTextDecoration = TextDecoration.Underline,
clickableStartIndex = linkStartIndex,
clickableEndIndex = linkEndIndex,
) {
onLearnMoreClicked(
"https://www.mozilla.org/en-US/firefox/pocket/?$POCKET_FEATURE_UTM_KEY_VALUE",
)
}
}
}
}
Expand Down

0 comments on commit 7ea1bd1

Please sign in to comment.