Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Support UI testing composables by using testTag #26826

Closed
Mugurell opened this issue Sep 5, 2022 · 3 comments · Fixed by #26843, #27843, nathanmkaya/fenix#108, fork-house/fenix#14 or Leland-Takamine/fenix#159
Closed

Support UI testing composables by using testTag #26826

Mugurell opened this issue Sep 5, 2022 · 3 comments · Fixed by #26843, #27843, nathanmkaya/fenix#108, fork-house/fenix#14 or Leland-Takamine/fenix#159
Assignees
@Mugurell
Milestone
108

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Sep 5, 2022 •
edited
Loading

After discussing with the QA team it was apparent that testing is currently hindered by the inability / inefficiency of identifying composables on the screen.
testTags are the approach recommended by the Compose team to help with that - https://developer.android.com/jetpack/compose/testing and we are already using them in A-C - https://searchfox.org/mozilla-mobile/search?q=testTag&path=&case=true&regexp=false

I propose starting to add (even retroactively for the scenarios raised by QA) testTags to the composables used on Fenix with the following naming scheme:

<feature>.<composable>(.<optional other sub composables>)

Compose v1.2 will also allow better interoperability with UIAutomator by allowing the testTags to be used in already common calls in the form of

findObject(By.res(<testTag>)).

An update to this newer version is prepared in #26763.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell mentioned this issue Sep 5, 2022
Merged
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 5, 2022
@Mugurell Mugurell removed the needs:triage Issue needs triage label Sep 6, 2022
@Mugurell Mugurell self-assigned this Sep 6, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 6, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the Pocket section.
2d153b5 
Split the ClickableSubstringLink to two separate strings which can be used
separately in UI tests.
Deleted the ClickableSubstringLink as it is now unused and although better
supports a link inside a string it's seen that it cannot be used in tests and
so we should also not use it in code.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 6, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent tabs section.
9820abf
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 6, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent visits section.
2a47c7c
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 6, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent bookmarks sec…
2524fff 
…tion.
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 6, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 14, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the Pocket section
3379b14
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 14, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent tabs section.
b76133e
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 14, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent visits section.
a7458c2
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 14, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent bookmarks sec…
b2a7ed7 
…tion.
@sv-ohorvath sv-ohorvath mentioned this issue Nov 7, 2022
Closed
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the Pocket section
7ea1bd1
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent tabs section.
bb2d4c6
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent visits section.
a5f89aa
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent bookmarks sec…
4103d16 
…tion.
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the Pocket section
9a854b7
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent tabs section.
f09d604
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent visits section.
acd12d3
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 8, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent bookmarks sec…
c73d238 
…tion.
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the Pocket section
81d60df
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent tabs section.
28ca437
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent visits section.
3c4542b
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent bookmarks sec…
be865a5 
…tion.
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the Pocket section
5aaa8d0
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent tabs section.
a7f1297
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 9, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags for the recent visits section.
ef409a8
mergify bot pushed a commit that referenced this issue Nov 9, 2022
@Mugurell @mergify
For #26826 - Add test tags for the Pocket section
f8c0ad0
mergify bot pushed a commit that referenced this issue Nov 9, 2022
@Mugurell @mergify
For #26826 - Add test tags for the recent tabs section.
5102adc
mergify bot pushed a commit that referenced this issue Nov 9, 2022
@Mugurell @mergify
For #26826 - Add test tags for the recent visits section.
0924de7
mergify bot pushed a commit that referenced this issue Nov 9, 2022
@Mugurell @mergify
For #26826 - Add test tags for the recent bookmarks section.
af8e364
@github-actions github-actions bot added this to the 108 milestone Nov 9, 2022
@github-actions github-actions bot reopened this Nov 9, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 9, 2022
@Mugurell
Copy link
Contributor Author

@sv-ohorvath / @AndiAJ to confirm that the new testTags do help automation testing.

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Nov 10, 2022
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 10, 2022

Thanks @Mugurell for helping us out ! ❤️

I'll remove the label, and if problems occur while trying query and to interact with the items will ping you.

Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 15, 2022
@Mugurell
For mozilla-mobile#26826 - Add test tags allowing to differentiate Po…
91b754f 
…cket stories
@github-actions github-actions bot mentioned this issue Nov 15, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 15, 2022
@mergify mergify bot closed this as completed in #27843 Nov 16, 2022
mergify bot pushed a commit that referenced this issue Nov 16, 2022
@Mugurell @mergify
For #26826 - Add test tags allowing to differentiate Pocket stories
a71aad1
@github-actions github-actions bot reopened this Nov 16, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 16, 2022
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Nov 17, 2022
This was referenced Dec 13, 2022
Merged
Merged
Merged
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807300

Change performed by the Move to Bugzilla add-on.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#26826 - Add test tags for the Pocket…
0d9892f 
… section
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#26826 - Add test tags for the recent…
e42f74f 
… tabs section.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#26826 - Add test tags for the recent…
606de8b 
… visits section.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#26826 - Add test tags for the recent…
8a3f470 
… bookmarks section.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#26826 - Add test tags allowing to di…
37b3829 
…fferentiate Pocket stories
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
None yet
Projects
None yet
Milestone
108
3 participants
@cpeterso @Mugurell @AndiAJ