New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seqwho #1503
Seqwho #1503
Conversation
@ewels any ideas when this can be merged in? |
I'm finally back to working 100% now, so soon hopefully! Hoping to find time to work through all of the open PRs in the next few weeks if all goes well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged with main, cleaned up, fixed the lining, and updated the column scales - the code looks good now! Thanks a lot for the contribution, @vsmalladi.
Just one question about the search pattern.
Thanks for getting this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the only bit I don't like is the "stacking": None,
. This means the plots scale badly, as if you have 100 samples there are now 400 bars which gets unreadable very fast. However, I understand that it's wrong to stack percentages, so I'm not sure I have a better solution.
We've had similar situations before and talked about using a Parallel Coordinates plot. This isn't supported by MultiQC currently (beyond a hacky version with a line plot), but we may be able to add it in the future with Plotly now. That could be something to think about if we want to come back to this in the future.
No better solution that I can think of for now, so happy to merge as-is. Thanks @vsmalladi !
CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)Close #1388