Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ccs #1593

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Fix ccs #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51aa8e7
FIX: Issue #1583
sguizard Nov 22, 2021
4a603b6
Update Changelog (issue 1583)
sguizard Nov 22, 2021
d39201b
👌 IMPROVE: Update: Module can be used on all report versions
sguizard Jan 20, 2022
1da4361
👌 IMPROVE: Reformat code with black
sguizard Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

- **CCS**
- Tolerate compound IDs generated by pbcromwell ccs in the general statistics ([#1486](https://github.com/ewels/MultiQC/pull/1486))
- Fix report parsing. Update test on attributes ids ([#1583](https://github.com/ewels/MultiQC/issues/1583))
- **Custom content**
- Fixed module failing when writing data to file if there is a `/` in the section name ([#1515](https://github.com/ewels/MultiQC/issues/1515))
- **DRAGEN**
Expand Down
7 changes: 6 additions & 1 deletion multiqc/modules/ccs/ccs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,12 @@ def filter_and_pass(self, data):

# Add filtere reasons (id starts with filtered_) and total passed
for entry in attributes:
if entry["id"].startswith("filtered") or entry["id"] == "zmw_passed_yield":
if (
entry["id"].startswith("filtered")
or entry["id"] == "zmw_passed_yield"
or entry["id"].startswith("ccs_processing.filtered")
or entry["id"] == "ccs_processing.zmw_passed_yield"
):
reasons[entry["name"]] = entry["value"]

return reasons
Expand Down