Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ccs #1593

Merged
merged 4 commits into from Jan 25, 2022
Merged

Fix ccs #1593

merged 4 commits into from Jan 25, 2022

Conversation

sguizard
Copy link
Contributor

The attributes in the report have been updated (+ "ccs_processing" at the beginning).
The failing test has been fixed.
Fix issue #1583

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

- attributes have been modified (+ "ccs_processing" at the beginning). The failing test has been fixed.
@sguizard
Copy link
Contributor Author

sguizard commented Nov 22, 2021

To pass, the tests needs to have the last version of ccs report.
I integrated those data in the PR 220

@Redmar-van-den-Berg
Copy link
Contributor

These changes break MultiQC for older versions of CCS. Can you update the code so that it works with all versions of CCS output, instead of only the latest?

@sguizard
Copy link
Contributor Author

@Redmar-van-den-Berg I corrected the test. The module works with all versions now.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍🏻

@ewels ewels merged commit d6ad632 into MultiQC:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants