Lint modules for missing self.add_software_version
#2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really-really love it! Thanks so much for the superfluous lines and for the CI check 🙏 |
…mdunk, snippy, snpeff, snpsplit, umitools, vep
…be called for any module
vladsavelyev
approved these changes
Sep 28, 2023
vladsavelyev
changed the title
self.add_software_version
|
@multiqc-bot changelog |
a-frantz
added a commit
to a-frantz/MultiQC
that referenced
this pull request
Oct 2, 2023
* master: Just run CI on the oldest + newest supported Python versions (MultiQC#2074) Picard: fix parsing mixed strings/numbers, account for trailing tab (MultiQC#2083) FastQC: add top overrepresented sequences table (MultiQC#2075) Add GitHub Actions bot workflow to fix code linting from a PR comment (MultiQC#2082) Use custom exception type instead of `UserWarning` when no samples are found. (MultiQC#2049) Lint modules for missing `self.add_software_version` (MultiQC#2081) Changelog bot: Update docs (MultiQC#2077) Changelog action: remove `.capitalize()`, add changelog entry (MultiQC#2080) Add action to populate the change log from PR titles triggered by `@multiqc-bot changelog` (MultiQC#2025) # Conflicts: # CHANGELOG.md # multiqc/modules/ngsderive/ngsderive.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2042
self.add_software_version.self.add_software_versioncallself.add_software_versioncalls are added.For some modules I could find version information in the logs but in files that are currently unparsed e.g.
dragen, or is missing from the current testdata e.g.fastp. I will raise separate issues for these.CHANGELOG.mdhas been updated