Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog action: remove .capitalize(), add changelog entry #2080

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

vladsavelyev
Copy link
Member

A follow up on #2025:

  • Do not run capitalize() on the entry as turns out it forces lowercase on all non-initial letters.
  • Add a missing changelog entry on the original PR :)

@vladsavelyev vladsavelyev added the core: infrastructure Something to do with the MultiQC infra label Sep 27, 2023
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You weren't tempted to use the bot on this PR? 😆

@ewels ewels merged commit 256fd77 into master Sep 27, 2023
10 checks passed
@ewels ewels deleted the changelog-changelog branch September 27, 2023 11:37
@vladsavelyev
Copy link
Member Author

You weren't tempted to use the bot on this PR? 😆

I couldn't before it was merged! Chicken and egg, classics

a-frantz added a commit to a-frantz/MultiQC that referenced this pull request Oct 2, 2023
* master:
  Just run CI on the oldest + newest supported Python versions (MultiQC#2074)
  Picard: fix parsing mixed strings/numbers, account for trailing tab (MultiQC#2083)
  FastQC: add top overrepresented sequences table (MultiQC#2075)
  Add GitHub Actions bot workflow to fix code linting from a PR comment (MultiQC#2082)
  Use custom exception type instead of `UserWarning` when no samples are found. (MultiQC#2049)
  Lint modules for missing `self.add_software_version` (MultiQC#2081)
  Changelog bot: Update docs (MultiQC#2077)
  Changelog action: remove `.capitalize()`, add changelog entry (MultiQC#2080)
  Add action to populate the change log from PR titles triggered by `@multiqc-bot changelog` (MultiQC#2025)

# Conflicts:
#	CHANGELOG.md
#	multiqc/modules/ngsderive/ngsderive.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core: infrastructure Something to do with the MultiQC infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants