Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to work with Astro 4 #2256

Merged
merged 12 commits into from Feb 12, 2024
Merged

Update docs to work with Astro 4 #2256

merged 12 commits into from Feb 12, 2024

Conversation

mashehu
Copy link
Collaborator

@mashehu mashehu commented Jan 3, 2024

Changes required for dependency updates on the website. See MultiQC/website#85

@ewels
Copy link
Member

ewels commented Jan 3, 2024

This is quite an irritating change, as it effectively breaks local development for anything involving images.

Is there no way to support relative image paths?

@mashehu
Copy link
Collaborator Author

mashehu commented Jan 4, 2024

okay, I think I found a work around 💡

@ewels
Copy link
Member

ewels commented Jan 8, 2024

Nice! Now just need to remember not to use the more obvious relative path. But that should be fine, as it won't work in the preview and can check the syntax of the other ones that do.. 😅

Thank you!

@ewels
Copy link
Member

ewels commented Jan 8, 2024

Waiting for MultiQC/website#85, for a simul-merge

@mashehu
Copy link
Collaborator Author

mashehu commented Jan 8, 2024

inline svg with relative links seem not possible at the moment. Needed to switch to linking to remote URL to get it to build. Otherwise this one is good to go now

@ewels
Copy link
Member

ewels commented Feb 12, 2024

@multiqc-bot changelog

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ewels ewels merged commit 7e2d79a into MultiQC:main Feb 12, 2024
2 of 3 checks passed
@mashehu mashehu deleted the fix-docs branch February 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants