Update dependencies #85
Conversation
mashehu
commented
Jan 3, 2024
mashehu
commented
- Update to astro 4, which requires changes in the docs (relative links for images stopped working), PR is incoming. Broke also the rehype-inline, so needed an astro element to render svgs inline.
- Includes also an update to astro-icon 1.0 and rehype-pretty-code, which required some changes.
- Updated also all other dependencies
❌ Deploy Preview for multiqc failed.
|
needs to be merged together with MultiQC/website#85
| sitemap(), | ||
| svelte(), | ||
| icon({ | ||
| include: { | ||
| // Include only subset of icon bundles |
There was a problem hiding this comment.
What's the reason for this chunk of config? To speed up builds?
There was a problem hiding this comment.
needed for astro-icon 1.0 https://www.astroicon.dev/guides/upgrade/v1/#changed-astro-icon-is-now-an-integration
There was a problem hiding this comment.
Right, the icon() bit is. But not the include:..?
There was a problem hiding this comment.
As in, what's the benefit over this?
There was a problem hiding this comment.
see warning in https://www.astroicon.dev/reference/configuration#include
src/pages/index.astro
Outdated
| class="logo w-full cursor-pointer" | ||
| width="550px" | ||
| height="110px" |
There was a problem hiding this comment.
| class="logo w-full cursor-pointer" | |
| width="550px" | |
| height="110px" | |
| class="logo h-28 max-w-full cursor-pointer" |
There was a problem hiding this comment.
Astro-icons needs a width, so I will use w-full instead of the proposed max-w-full
There was a problem hiding this comment.
ok, as long as that doesn't mess with the aspect ratio. If they can do without a height then you could instead do this:
class="logo w-[550px] max-w-full cursor-pointer"There was a problem hiding this comment.
Needs also a height, but then your code works and is added in 0418564
|
Both PRs should be good to go now |
|
Netlify was pinned on Node 16, which I think is why the build was failing. Just updated to Node 20 |
|
gah, settings and also in the netlify toml file 😅 |
|
ok, failing but for a different reason now - needs the PR from MultiQC itself. Will merge and see if I can get everything to build. Thanks! |
* changes necessary with the update astro version * changes necessary with the updated astro version needs to be merged together with MultiQC/website#85 * [automated] Update CHANGELOG.md * jump around a bit more to make relative links work * fix svg, needs to be remote 😞 --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
