Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hifiasm: account for lines with no asterisk #2268

Merged
merged 3 commits into from Jan 19, 2024
Merged

Hifiasm: account for lines with no asterisk #2268

merged 3 commits into from Jan 19, 2024

Conversation

mbeavitt
Copy link
Contributor

@mbeavitt mbeavitt commented Jan 19, 2024 •
edited by ewels

  • This comment contains a description of changes (with reason)
  • There is example tool output for tools in the https://github.com/MultiQC/test-data repository or attached to this PR
  • Code is tested and works locally (including with --strict flag)
  • docs/README.md is updated with link to below
  • docs/modulename.md is created
  • Everything that can be represented with a plot instead of a table is a plot
  • Report sections have a description and help text (with self.add_section)
  • There aren't any huge tables with > 6 columns (explain reasoning if so)
  • Each table column has a different colour scale to its neighbour, which relates to the data (eg. if high numbers are bad, they're red)
  • Module does not do any significant computational work

The hifiasm module doesn't account for kmer graphs which do not start with an asterisk. It is unknown if this is a recent update, or just something that occurs on small input data.

I have updated it to check whether a kmer graph line starts with an asterisk, and use a different strategy if not.

@mbeavitt mbeavitt mentioned this pull request Jan 19, 2024
Closed
4 tasks
@mbeavitt
Copy link
Contributor Author

mbeavitt commented Jan 19, 2024 •
edited

ah, weird, I committed with my work account. sorry about that. hope it's all fine anyhow

@vladsavelyev vladsavelyev changed the title changed hifiasm module to account for lines with no asterisk Hifiasm: account for lines with no asterisk Jan 19, 2024
@vladsavelyev
Copy link
Member

@multiqc-bot changelog

@vladsavelyev vladsavelyev self-requested a review January 19, 2024 21:32
@vladsavelyev vladsavelyev added the bug: module Bug in a MultiQC module label Jan 19, 2024
@vladsavelyev vladsavelyev added this to the MultiQC v1.20 milestone Jan 19, 2024
vladsavelyev
vladsavelyev approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@vladsavelyev vladsavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@vladsavelyev vladsavelyev merged commit d11815a into MultiQC:main Jan 19, 2024
6 checks passed
@mbeavitt
Copy link
Contributor Author

glad to be of service!

Officially my first ever contribution to open source code 😄

@ewels
Copy link
Member

ewels commented Jan 23, 2024

Congratulations @mbeavitt - welcome to the team! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladsavelyev vladsavelyev vladsavelyev approved these changes

Assignees
No one assigned
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Milestone
MultiQC v1.20: Plotly
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbeavitt @vladsavelyev @ewels @mbeavitt-bh @multiqc-bot