Replace setup.py with pyproject.toml
#2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsavelyev
added
the
core: infrastructure
ewels
reviewed
Feb 21, 2024
Merged
vladsavelyev
added a commit
that referenced
this pull request
Feb 23, 2024
ewels
added a commit
that referenced
this pull request
Feb 24, 2024
* Rewrite version checker to use new API endpoint * Move version_check_url into the config, for local testing * Version check URL * Clean up * Typo * Parse CI env var * Fix * Catch timeout error * UMI-tools: support `extract` command (#2296) * UMI-tools: support extract command * [automated] Update CHANGELOG.md * Add barplot * Barplot with extract stats * Doc * Changelog * Lint * Fix duplicated IDs in linting * Merge conflict --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Phil Ewels <phil.ewels@seqera.io> * Infinite dmax or dmin fail JSON dump load in JavaScript (#2354) * Infinite dmax or dmin fail JSON dump load in JavaScript * [automated] Update CHANGELOG.md --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Fix changelog.py for module updates * Whatshap: robust to stdout appended to TSV (#2361) * Drop `full_figure_for_development` the call to avoid Kaleido issues (#2359) * Wrap `full_figure_for_development` in try-except to handle Kaleido errors * [automated] Update CHANGELOG.md * Get around read-only /tmp * Remove the full_figure_for_development call for good, just re-calcualte range from data * Changelog * Comments --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * PURPLE: support v4.0.1 output without `version` column (#2366) * Purple: support v4.0.1 output without version column * [automated] Update CHANGELOG.md * [automated] Update CHANGELOG.md --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Ignore `.parquet` files. More robust `htseq` file reading loop (#2364) * Ignore .parquet files. Handle htseq unicode errors * [automated] Update CHANGELOG.md --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Add box plot (#2358) * Add box plot * [automated] Update CHANGELOG.md * Fix linting * CSP * Fix sample order * Allow overriding title for a dataset tab * Violin: color dots blue in monochrome violins to indiciate interactivity * Mono color for boxes, support highliting * Rename beeswarm to violin * Barplot: stacking: normal should mean stacked, not grouped * Update plotting documentation * Docs * Redirect beeswarm * CSP * Update the flat plot section and remove highcharts mention --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Replace `setup.py` with `pyproject.toml` (#2353) * Replace setup.py with pyproject.toml * [automated] Update CHANGELOG.md * Add myself as author --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Put matplotlib back into main deps (#2370) * Put matplotlib back into main deps * [automated] Update CHANGELOG.md --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Generic font family for Plotly (#2368) * Generic font family for Plotly * [automated] Update CHANGELOG.md --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Phil Ewels <phil.ewels@seqera.io> * Samtools `coverage` submodule (#2356) * Allow override title per-dataset * Add samtools coverage submodule * [automated] Update CHANGELOG.md * Fix changelog * Update multiqc/modules/samtools/rmdup.py Co-authored-by: Phil Ewels <phil.ewels@seqera.io> * Fix rmdup regex --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Phil Ewels <phil.ewels@seqera.io> * Update `modules.md`: `pyproject.toml`, `"shared_key": "read_count"`, ruffify (#2371) * Update modules.md: `pyproject.toml`, `"shared_key": "read_count"`, ruffify * [automated] Update CHANGELOG.md * Apply suggestions from code review --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Phil Ewels <phil.ewels@seqera.io> --------- Co-authored-by: Vlad Savelyev <vladislav.sav@gmail.com> Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io>
Zethson
reviewed
Feb 28, 2024
| ] | ||
| dev = [ | ||
| "pre-commit", | ||
| "ruff", |
There was a problem hiding this comment.
You already have that as part of pre-commit. Why are you installing it again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
uv pipneeds it to work in the editable mode, it's a good time to switch to the modern build setup.Following the guides at:
https://packaging.python.org/en/latest/guides/writing-pyproject-toml
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html