Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style improvements #1

Open
5 tasks
MultiW opened this issue Apr 23, 2021 · 0 comments
Open
5 tasks

Code style improvements #1

MultiW opened this issue Apr 23, 2021 · 0 comments
Labels
code style

Comments

@MultiW
Copy link
Owner

MultiW commented Apr 23, 2021 •
edited
Loading

  • Move util files from data to a new util folder. Only the clean_* and build_features files should be in data.
  • Merge clean_labels and clean_dataset
  • Re-organize train.py and predict.py. E.g. separate "evaluate" functions from predict.py
  • Define the data types in the labels matrix more explicitly. Converting labels to and from pickle files makes the data type inconsistent.
  • Fix inconsistencies in low-pass filters between training and predicting
@MultiW MultiW changed the title Code Style Improvements Code style improvements Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MultiW