Cannot set song duration through tags with addtagid

[X-dark]

Hi,

Among tags, the duration seems to be defined:

MPD/src/tag/Tag.hxx

Line 24 in 53ec02d

SignedSongTime duration = SignedSongTime::Negative();

However there does not seem to be a way to set this through addtagid:

MPD/src/tag/Type.hxx

Lines 11 to 48 in 53ec02d

	enum TagType : uint8_t {
	TAG_ARTIST,
	TAG_ARTIST_SORT,
	TAG_ALBUM,
	TAG_ALBUM_SORT,
	TAG_ALBUM_ARTIST,
	TAG_ALBUM_ARTIST_SORT,
	TAG_TITLE,
	TAG_TITLE_SORT,
	TAG_TRACK,
	TAG_NAME,
	TAG_GENRE,
	TAG_MOOD,
	TAG_DATE,
	TAG_ORIGINAL_DATE,
	TAG_COMPOSER,
	TAG_COMPOSERSORT,
	TAG_PERFORMER,
	TAG_CONDUCTOR,
	TAG_WORK,
	TAG_MOVEMENT,
	TAG_MOVEMENTNUMBER,
	TAG_ENSEMBLE,
	TAG_LOCATION,
	TAG_GROUPING,
	TAG_COMMENT,
	TAG_DISC,
	TAG_LABEL,
	TAG_MUSICBRAINZ_ARTISTID,
	TAG_MUSICBRAINZ_ALBUMID,
	TAG_MUSICBRAINZ_ALBUMARTISTID,
	TAG_MUSICBRAINZ_TRACKID,
	TAG_MUSICBRAINZ_RELEASETRACKID,
	TAG_MUSICBRAINZ_WORKID,
	TAG_NUM_OF_ITEM_TYPES
	};

As a result, external clients like upmpdcli that add streaming tracks to mpd, cannot set the duration and it stays at 0:00, until mpd start playing the track. This breaks other tools that relies on track duration as soon as they are in the playlist.

[MaxKellermann]

This bug report makes no sense because a song duration is not a tag.

[X-dark]

OK, then what would be the proper way to get the track to have its duration set as soon as it is added to the playlist?

[MaxKellermann]

Not at all. Let MPD figure it out automatically, as you already described.

[X-dark]

Yes, but as I have been trying to explain, the duration is unset until the track get played:

❯ mpc playlist --format='%position% - %artist% - %title% - %time%'
[...]
50 - Lars Danielsson - Intermedium -
51 - Lars Danielsson - III. Le Bagatelle -
52 - Lars Danielsson - IV. Scherzo -
[...]

❯ mpc
Lars Danielsson - III. Le Bagatelle
[playing] #51/62   1:32/13:38 (11%)
volume:100%   repeat: off   random: off   single: off   consume: off

[MaxKellermann]

I know.

This breaks other tools that relies on track duration as soon as they are in the playlist.

These tools are broken. Don't use them or fix them.