Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with updated ClassLoader? #249

Closed
kawaii opened this issue Jun 16, 2019 · 9 comments · Fixed by #327
Closed

Incompatibility with updated ClassLoader? #249

kawaii opened this issue Jun 16, 2019 · 9 comments · Fixed by #327
Milestone

Comments

@kawaii
Copy link

kawaii commented Jun 16, 2019

Warning [2] require_once(/var/www/html/inc/plugins/MybbStuff/CoreClassLoader.php): failed to open stream: No such file or directory - Line: 26 - File: inc/plugins/myalerts.php PHP 7.3.4 (Linux)
Fatal error: require_once(): Failed opening required '/var/www/html/inc/plugins/MybbStuff/CoreClassLoader.php' (include_path='.:/usr/local/lib/php') in /var/www/html/inc/plugins/myalerts.php on line 26

When visiting admin/index.php?module=config-plugins after uploading the latest version of MyAlerts from GitHub.

@WildcardSearch
Copy link
Contributor

@kawaii iirc you have to grab that from here: https://github.com/MyBBStuff/Plugins.Core

@kawaii
Copy link
Author

kawaii commented Jun 16, 2019

@WildcardSearch ah there's actually a new version of the ClassLoader distributed with Euan's more recent plugins (such as mybb-prometheus and the updated version of SimpleLikes which you can see here). The issue is that MyAlerts needs updating too now to take advantage of it due to the changes in how namespaces are handled. :)

@WildcardSearch
Copy link
Contributor

Okay...that error message indicates that the class loader is missing...not the wrong version.

@kawaii
Copy link
Author

kawaii commented Jun 16, 2019

In this case MyAlerts can't even ascertain the correct location of ClassLoader due to the incompatibility, if you read the error message you'll note the CoreClassLoader.php reference instead of the usual Core/ClassLoader.php indication that it's missing.

@WildcardSearch
Copy link
Contributor

Indeed. My curiosity is now satisfied. Thanks.

@euantorano euantorano added this to the v2.0.5 milestone Nov 6, 2019
@YashvirGaming
Copy link

Thanks I upload that ClassLoader.php in the Core folder and refresh the adminCP plugin page and works like a charm

image

@Eldenroot
Copy link
Contributor

@lairdshaw - what about to include this library into myalerts package? Or display a notification in ACP (plugin page) that it is missing...

@lairdshaw
Copy link
Contributor

I don't think inclusion is a good idea, because we want people to install the latest version. Notification display could be a good idea because people regularly report white screen errors on the ACP Plugins page which are a result of failing to install PluginLibrary (and/or Plugins.Core).

@Eldenroot
Copy link
Contributor

This one wpuld be nice for 2.1.0 @lairdshaw

lairdshaw added a commit to lairdshaw/MyAlerts that referenced this issue Mar 7, 2024
euantorano added a commit that referenced this issue Mar 23, 2024
Fix #249 by erroring out when missing PluginLibrary or Plugins.Core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants