Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSP err and add 0x Instant Err message #2346

Merged
merged 4 commits into from
Jan 10, 2019

Conversation

blurpesec
Copy link
Collaborator

Closes #2345.

Description:

Fixes issue with 0x Instant CSP in desktop app and adds an error message on 0x-Instant page in desktop app since it's not usable due to lack of Metamask in electron.

Changes Made:

  • Edited CSP to add https:// to hostnames for 0x.mycrypto.com.
  • Added Warning message for 0x Instant swap page.

Steps to Test:

  1. Open desktop app.
  2. Navigate to Swap tab
  3. Select the 0x Instant Option.
  4. You should see this now instead of the empty box:

looks good

@coveralls
Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage remained the same at 53.302% when pulling ecae9d3 on blurpesec:fix-csp-err into 9f46157 on MyCryptoHQ:develop.

@SharonManrique SharonManrique added the status: approved by qa Open PR's once approved by QA. label Jan 10, 2019
@ConnorBryan ConnorBryan merged commit 0ccae58 into MyCryptoHQ:develop Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved by qa Open PR's once approved by QA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants