Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 0x Instant Swap Fee for MyCrypto #2347

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Added 0x Instant Swap Fee for MyCrypto #2347

merged 3 commits into from
Jan 10, 2019

Conversation

blurpesec
Copy link
Collaborator

@blurpesec blurpesec commented Jan 10, 2019 •
edited
Loading

Description

Adds 3% fee for MyCrypto 0x swaps to help generate revenue.

Changes

  • Added constant for fee receiver address.
  • Added constant for fee percentage (as a decimal). (set at 3% - 0.03)

Steps to Test

  1. Open the swap tab at https://mycrypto.com/swap/0x
  2. Initiate a swap to buy 5 Dai.
  3. Notice that there is now a fee of 3%.
  4. Send the swap.
  5. Once it completes, navigate to the fee receiver address and notice that it has received ETH in the internal transactions section of Etherscan.

Screenshots

0x fee 1

0x fee 2

0x fee 3

@blurpesec blurpesec changed the title Added 0x fee for MyCrypto Added 0x Instant Swap Fee for MyCrypto Jan 10, 2019
@coveralls
Copy link

coveralls commented Jan 10, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 53.302% when pulling ea7dc2a on blurpesec:0x-fee-addition into 9f46157 on MyCryptoHQ:develop.

@ConnorBryan ConnorBryan merged commit eb59b99 into MyCryptoHQ:develop Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blurpesec @coveralls @ConnorBryan