Skip to content

PR Requirements

Sergiu Muresan edited this page Sep 11, 2015 · 5 revisions

Please follow the Do's and Don'ts listed below. If you don't, there is a good chance we will just close your PR without looking at it.

Do's

  1. Provide detailed information as to what your PR is suppose to fix.
  2. If its a fix to a crash, the crash report and/or log would be useful so we can learn from it and improve upon your PR if necessary.
  3. Only work against the Master branch, any other branches should be considered unstable and potentially dangerous.

Dont's

  1. Do NOT change the formatting. Why? Because we prefer the format and have agreed upon it across the projects. We want everything to be consistent.
  2. Do NOT merge branches other than Master into your own PR. It WILL be rejected!