Unifies master & windows development branches #8
Conversation
win/logging.properties
Outdated
| @@ -0,0 +1,5 @@ | |||
| handlers=java.util.logging.FileHandler | |||
| java.util.logging.FileHandler.formatter=java.util.logging.SimpleFormatter | |||
| java.util.logging.FileHandler.pattern=%h/Library/Application\ Support/zcash4mac/zcash4mac.log | |||
There was a problem hiding this comment.
This probably needs to be changed, we don't want to log to the zcash4mac log file 😈
There was a problem hiding this comment.
I'm not sure at this point if it's even used but I'll update it in case (to be later validated)
win/first-run.bat
Outdated
| echo addnode=explorer.myhush.org | ||
| echo addnode=hushipv4.matthewreichardt.com | ||
| echo addnode=mmc01.madbuda.me | ||
| echo addnode=stilgar.leto.net |
There was a problem hiding this comment.
hushipv4.matthewreichardt.com, node.myhush.network and mmc01.madbuda.me are no longer up, they were run by former core devs.
My server stilgar also has the hostname of stilgar.myhush.org now, please use that.
Our DNS Seed host should also be added here: dnsseed.myhush.org. Currently it is not working, but I think we can believe it will be working soon, and add it as a node for people. When it does work, it will greatly help new nodes sync to the network.
| @@ -570,6 +571,12 @@ public static void possiblyCreateHUSHConfigFile() | |||
| configOut.println("rpcpassword=Pass" + Math.abs(r.nextInt()) + "" + | |||
| Math.abs(r.nextInt()) + "" + | |||
| Math.abs(r.nextInt())); | |||
| configOut.println("addnode=node.myhush.network"); | |||
There was a problem hiding this comment.
Please remove the same nodes here and update stilgar to stilgar.myhush.org. The host zdash.suprnova.cc seems to be good still, that can be kept. And dnsseed.myhush.org
| @@ -6,7 +6,7 @@ | |||
| * /____\____\__,_|___/_| |_|____/ \_/\_/ |_|_| |_|\__, | \_/\_/ \__,_|_|_|\___|\__|\___/|___| | |||
| * |___/ | |||
| * | |||
| * Copyright (c) 2016 Ivan Vaklinov <ivan@vaklinov.com> | |||
| * Copyright (c) 2017-2018 The Hush Developers <contact@myhush.org> | |||
There was a problem hiding this comment.
Instead of removing the copyright line, it's is more appropriate and correct to add a brand new line, leaving
the old copyright years and names alone. So just keep your current Copyright line and revive the line that was deleted. For example, here is a copyright lines of the src/rpcmining.cpp file from hush.git:
src/rpcmining.cpp
1:// Copyright (c) 2010 Satoshi Nakamoto
2-// Copyright (c) 2009-2014 The Bitcoin Core developers
3-// Copyright (c) 2017 The Hush developers
Please fix this each file, since we want to give credit where credit is due.
This pull request's goals are to accomplish the following:
Minor side-bonuses:
Follow-up work coming down the pipeline, enabled in part by the branch unification:
finalcorrectness*.exe); replacing them with release file fetch & hash check or build as part of the GUI build processSo if you notice the above are missing, they'll be coming :)