Absurd fee bug #136
Merged
Absurd fee bug #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We inherited this bug from upstream, and most Zcash forks probably have similar behavior. Upstream issue: zcash/zcash#3281
|
FYI All tests wallet.py tests pass for me on Ubuntu 16.04 . To run the tests for this PR: |
FireMartZ
approved these changes
Jun 22, 2018
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jul 17, 2018
Fix absurd fee bug reported in #3281, with tests This was ported from the Hush `absurd_fee_bug` PR: MyHush/hush#136 Tests executed with `./qa/pull-tester/rpc-tests.sh wallet` and pass on Ubuntu 16.04. Some tests were added for previously untested behavior as well. Closes #3281.
|
FYI I forgot to merge this and it should be in our next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "absurd fee bug" for small transaction amounts (when amount < fee), more details here:
zcash/zcash#3281
This directly effects HushList protocol, since HushList wants to be able to send amount=0 transactions with default fee, but Zcash upstream currently has a bug which forces a non-default fee, which leaks metadata.
Most likely all Zcash forks have this bug, except the ones that haven't merged since Zcash introduced this from BTC upstream.