-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic HMAC and HKDF functions #38
Conversation
lgtm! thanks for the comprehensive test cases, we can perhaps port over https://github.com/google/wycheproof/blob/master/testvectors/hmac_sha256_test.json wycheproof test cases in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benr-ml let's please rebase before merging; after recent merges there are now small conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!
commit 6c679f7 Author: Jonas Lindstrøm <jonas-lj@users.noreply.github.com> Date: Fri Sep 23 20:43:55 2022 +0200 Include hash functions (SHA-2, SHA-3, Keccak and SHAKE2) (#63) commit 4b7a06f Merge: 49b6cf7 aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:30:18 2022 -0400 Merge pull request #52 from MystenLabs/ci1 Fix publish.yml commit aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:17:53 2022 -0400 remove public-api from workflow commit 5550248 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Sun Sep 18 20:03:41 2022 -0400 ci fix commit 49b6cf7 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 21:09:14 2022 +0300 update public-api (#59) commit 8cec139 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 19:49:47 2022 +0300 Add basic HMAC and HKDF functions (#38)
* Bump blake2 from 0.9.2 to 0.10.4 Bumps [blake2](https://github.com/RustCrypto/hashes) from 0.9.2 to 0.10.4. - [Release notes](https://github.com/RustCrypto/hashes/releases) - [Commits](RustCrypto/hashes@blake2-v0.9.2...blake2-v0.10.4) --- updated-dependencies: - dependency-name: blake2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Squashed commit of the following: commit 6c679f7 Author: Jonas Lindstrøm <jonas-lj@users.noreply.github.com> Date: Fri Sep 23 20:43:55 2022 +0200 Include hash functions (SHA-2, SHA-3, Keccak and SHAKE2) (#63) commit 4b7a06f Merge: 49b6cf7 aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:30:18 2022 -0400 Merge pull request #52 from MystenLabs/ci1 Fix publish.yml commit aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:17:53 2022 -0400 remove public-api from workflow commit 5550248 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Sun Sep 18 20:03:41 2022 -0400 ci fix commit 49b6cf7 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 21:09:14 2022 +0300 update public-api (#59) commit 8cec139 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 19:49:47 2022 +0300 Add basic HMAC and HKDF functions (#38) * Update usage of blake2b crate to new version * Fix fmt Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonas Lindstrøm <jonas-lj@users.noreply.github.com>
Both use SHA256 as the underlying hash function.
#39