Fix publish.yml #52
Merged
Fix publish.yml #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
previously approved these changes
Sep 19, 2022
.github/workflows/publish.yml
Outdated
| @@ -3,6 +3,7 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - ci1 | |||
There was a problem hiding this comment.
just for testing, removed.
joyqvq
force-pushed
the
ci1
branch
6 times, most recently
from
07fcd77
to
20a10d9
Compare
|
after taking a closer look on https://crates.io/crates/cargo-semver-checks it achieves the same goal as crate-public-api by detecting api changes. it generates a temp file of the API in the current repo and against the published version. instead of committing to a json file, it will fail on the workflow if API change is detected, but the crate version is not bumped on major release. hence removing the public-api from CI |
kchalkias
reviewed
Sep 19, 2022
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "fastcrypto" | |||
| version = "0.1.3" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
do want to make it v1? I'd expect that 1.0.0 would only make sense a few months later when fastcrypto is definitely stabilized and most of the original features are functional + benchmarks.
There was a problem hiding this comment.
MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards compatible manner
PATCH version when you make backwards compatible bug fixes
^ following what semver CI is set to - since the API did change, we should probably increment MAJOR
jonas-lj
added a commit
that referenced
this pull request
Sep 26, 2022
commit 6c679f7 Author: Jonas Lindstrøm <jonas-lj@users.noreply.github.com> Date: Fri Sep 23 20:43:55 2022 +0200 Include hash functions (SHA-2, SHA-3, Keccak and SHAKE2) (#63) commit 4b7a06f Merge: 49b6cf7 aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:30:18 2022 -0400 Merge pull request #52 from MystenLabs/ci1 Fix publish.yml commit aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:17:53 2022 -0400 remove public-api from workflow commit 5550248 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Sun Sep 18 20:03:41 2022 -0400 ci fix commit 49b6cf7 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 21:09:14 2022 +0300 update public-api (#59) commit 8cec139 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 19:49:47 2022 +0300 Add basic HMAC and HKDF functions (#38)
jonas-lj
added a commit
that referenced
this pull request
Sep 26, 2022
* Bump blake2 from 0.9.2 to 0.10.4 Bumps [blake2](https://github.com/RustCrypto/hashes) from 0.9.2 to 0.10.4. - [Release notes](https://github.com/RustCrypto/hashes/releases) - [Commits](RustCrypto/hashes@blake2-v0.9.2...blake2-v0.10.4) --- updated-dependencies: - dependency-name: blake2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Squashed commit of the following: commit 6c679f7 Author: Jonas Lindstrøm <jonas-lj@users.noreply.github.com> Date: Fri Sep 23 20:43:55 2022 +0200 Include hash functions (SHA-2, SHA-3, Keccak and SHAKE2) (#63) commit 4b7a06f Merge: 49b6cf7 aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:30:18 2022 -0400 Merge pull request #52 from MystenLabs/ci1 Fix publish.yml commit aa215c8 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Mon Sep 19 16:17:53 2022 -0400 remove public-api from workflow commit 5550248 Author: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Sun Sep 18 20:03:41 2022 -0400 ci fix commit 49b6cf7 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 21:09:14 2022 +0300 update public-api (#59) commit 8cec139 Author: benr-ml <112846738+benr-ml@users.noreply.github.com> Date: Mon Sep 19 19:49:47 2022 +0300 Add basic HMAC and HKDF functions (#38) * Update usage of blake2b crate to new version * Fix fmt Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonas Lindstrøm <jonas-lj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.