Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clRateMetalTable(): roundoff issue when checking for table overflow #118

Open
trquinn opened this issue Jul 12, 2022 · 0 comments
Open

clRateMetalTable(): roundoff issue when checking for table overflow #118

trquinn opened this issue Jul 12, 2022 · 0 comments

Comments

@trquinn
Copy link
Member

trquinn commented Jul 12, 2022

The checks for table overflow/underflow in clRateMetalTable() in cooling_metal.c and cooling_metal_H2.c have roundoff problems. E.g. if cl->z is greater than cl->MetalzMin by an amount that will be lost in roundoff when calculating "xz", there will be a table overflow. The "EPS" should be included in the if() test to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant