Does not work any more (5th January 2024)

[ChrisJan00]

Hello. I downloaded this extension from the Firefox addons page months ago, and have been happily using it all along.

Today it stopped working. I was using it a couple of days ago, it only started failing now.

The Javascript console shows a bunch of errors "Content-Security-Policy: The page’s settings blocked the loading of a resource at ...".

I have not updated Firefox in weeks, and this just started happening now, so probably the Github people just changed something that broke the extension. Hopefully you can figure a workaround to make it work again. This awesome addon is missed.

Not sure if it matters:
Firefox version 119.0 (64-bit)
Gifs For Github version 23.11.6

[mxosman]

Experiencing the same thing with the extension not working in Chrome. It appears to be CSS related as it's rendering in the DOM, just behind other elements.

The problematic CSS class I noticed is select-menu-modal-right in the giphy-toolbar-item.js component:

<details class="details-reset details-overlay toolbar-item select-menu select-menu-modal-right ghg-trigger btn-octicon">
...

The position: relative; seems to be clashing with the toolbar. When removed, the dropdown renders as usual (though the top margin is slightly off).

Happy to open a PR if granted write permissions - otherwise, my naive proposal (assuming no other issues) would be to adjust L5 in giphy-toolbar-item.js to remove the select-menu-modal-right class and adjust the styling slightly:

  <details
    class="details-reset details-overlay toolbar-item select-menu ghg-trigger btn-octicon"
    style={{ 'margin-top': '4px' }}
  >

[N1ck]

Thank you for reporting that the extension stopped working. You're right, GitHub has made some changes that caused the extension to break.

The fix for the recent changes are here: https://github.com/N1ck/gifs-for-github/pull/69/files (plus this sneaky additional fix here)

It is already available in version 24.1.6, currently just in FIrefox and is awaiting review to be updated in Chrome but should be soon 🤞. I'll leave this issue open until I know it's out.

Thank you very much @mxosman also for investigating.

[ChrisJan00]

Thank you! It's working again! ❤️

[mxosman]