Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require license_url, add attribution fields #182

Merged
merged 12 commits into from
Jan 25, 2020
Merged

Require license_url, add attribution fields #182

merged 12 commits into from
Jan 25, 2020

Conversation

antrim
Copy link
Contributor

@antrim antrim commented Oct 9, 2019

license_url is an optional field in system_information.json (added in PR #49). This new pull request would make a backwards-compatibility breaking change to define license_url as mandatory. The outcome of the discussion related to versioning (issue #15) would define how such a change would be treated and incorporated into the spec.

This proposal would:

  • Make feed_license a mandatory field.
  • Add statement that a license_url being present but empty means the feed is released without a license (public domain).
  • Add fields for attribution to the GBFS, partially borrowed from this GTFS-Attributions proposal.
  • Add a limited inventory of licenses to the GBFS wiki, with implications of each.

Make license_url "Required", add attribution fields and add inventory of common data licenses.
@yocontra
Copy link
Contributor

Can we use SPDX license IDs? This is what most OSS tools have converged around, and I think it makes sense here as well.

@antrim
Copy link
Contributor Author

antrim commented Oct 10, 2019

@contra : Makes good sense. I'll revise the PR.

SPDX License List
Creative Commons Universal Public Domain Dedication
(added text for 'license_url')
@antrim
Copy link
Contributor Author

antrim commented Nov 21, 2019

I've revised the PR:

  • Added license_id. This is a string that refers to the SPDX identifier.
  • license_url and license_id are both conditionally required. Only one should be provided. If a standard license then feed publishers should specify license_id; if custom, then license_url.

Since the introduced requirement makes the change backwards-compatibility breaking, then this would need to be part of a MAJOR version. (see #188)

What this PR does NOT currently do:

  • Make any recommendation with regard to particular licenses or custom vs. standard licenses. I was tempted to include a recommendation to use a standard license, but thought better of writing that sort of practice recommendation into the specification, at least before there is a more thorough research and stakeholder interview process.
  • Allow SPDX License Expressions. This would allow multiple standard licenses to be applied or a standard license to be applied with modifications. I figured this would just add complexity now, and could be added later if necessary. LMK if that's wrong and this would be used immediately.

christrillium and others added 3 commits November 22, 2019 14:24
update column name and link
clarify identifiers and names
expand the full names of licenses
@antrim
Copy link
Contributor Author

antrim commented Nov 25, 2019

I hereby call a vote on this proposal. Because of the US Thanksgiving holiday, I propose we extend by 1 day. Voting will be open for 8 full days, until 11:59PM UTC on Tuesday, Dec 3.

Please vote for or against the proposal to add a data license, and include the organization for which you are voting in your comment.

@barbeau
Copy link
Member

barbeau commented Nov 25, 2019

@antrim I know in some states (including Florida) Thursday and Friday are both considered holidays:
https://www.dms.myflorida.com/workforce_operations/human_resource_management/for_state_personnel_system_hr_practitioners/state_holidays

...so I'd suggest giving two additional days to account for this.

@antrim
Copy link
Contributor Author

antrim commented Nov 27, 2019

Following @barbeau 's suggestion, I'd like to extend the voting period until 11:59PM UTC on Dec 6 to accommodate the USA Thanksgiving holiday.

Please vote, and note if you can commit to implementing this proposal.

@yocontra
Copy link
Contributor

yocontra commented Dec 2, 2019

+1 from Stae

@madupras
Copy link
Contributor

madupras commented Dec 3, 2019

+1 from PBSC

@quicklywilliam
Copy link

+1 Ride Report

@evansiroky
Copy link
Contributor

+1 from IBI Group

Note: I think we should change the markdown style so that there are not extra spaces in the tables. When we change the column widths it makes it harder to do line-by-line comparisons in GitHub.
makes it easier to read
@antrim
Copy link
Contributor Author

antrim commented Dec 7, 2019

Voting has closed and this changed has been passed. Four votes were in favor:

  • IBI Group (Developer of OpenTripPlanner, GBFS consumer)
  • Stae (Vendor)
  • PBSC (Vendor / GBFS producer)
  • Ride Report (GBFS consumer)

@MobilityData is refining how we'll implement the versioning scheme (#188). We'll merge this once we arrive at a sensible release process (see #163).

@antrim antrim added the v2.0 Candidate change for GBFS 2.0 (Major release) label Jan 3, 2020
@antrim antrim merged commit bab4dab into master Jan 25, 2020
@antrim
Copy link
Contributor Author

antrim commented Jan 26, 2020

Merged - branch deleted.

@antrim antrim deleted the licensing branch January 26, 2020 23:23
@heidiguenin
Copy link
Contributor

We'd love to make this an official part of the spec, but first we need to see this change being implemented. Could you comment here if your organization has implemented this? [Sorry to those of you fabulously active community members who will see this message over and over again today!]

@evansiroky @quicklywilliam @madupras @contra Others?

@madupras
Copy link
Contributor

We still have multiple months before tackling this change at PBSC. It's in our "GBFS version 2" internal project which is planned for the Q3/Q4 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md proposal:breaking v2.0 Candidate change for GBFS 2.0 (Major release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants