Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Region Bounding Volume #66

Closed
gkjohnson opened this issue May 23, 2020 · 3 comments · Fixed by #286
Closed

Add support for Region Bounding Volume #66

gkjohnson opened this issue May 23, 2020 · 3 comments · Fixed by #286
Labels
enhancement New feature or request
Milestone

Comments

@gkjohnson
Copy link
Contributor

gkjohnson commented May 23, 2020

Regions should be specified in the local frame of the group treating the group as the WGS84 coordinate frame.

Example data here.

Spec here.

More information in CesiumGS/3d-tiles#445

@gkjohnson gkjohnson added the enhancement New feature or request label May 29, 2020
@gkjohnson gkjohnson added the help wanted Extra attention is needed label Jun 12, 2020
@gkjohnson gkjohnson added this to the Feature Complete milestone Jun 12, 2020
@gkjohnson
Copy link
Contributor Author

gkjohnson commented Dec 10, 2020

Add support for:

  • A Region class
  • A RegionHelper class for rendering a region
  • A displayBoundingRegion flag for debug tiles renderer

The region must be defined on the oblate WGS84 spheroid with major and minor axes defined here

@gkjohnson gkjohnson modified the milestones: Feature Complete, v0.2.1 Dec 12, 2020
@gkjohnson gkjohnson removed the help wanted Extra attention is needed label Dec 12, 2020
@gkjohnson gkjohnson modified the milestones: v0.2.1, v0.2.3 Dec 24, 2020
@gkjohnson gkjohnson modified the milestones: v0.2.3, v0.2.4, v0.2.5, v0.2.6 Jan 16, 2021
@gkjohnson gkjohnson modified the milestones: v0.2.6, v0.2.7, v0.2.8 Feb 4, 2021
@gkjohnson gkjohnson modified the milestones: v0.2.9, v0.2.10 Mar 26, 2021
@gkjohnson gkjohnson modified the milestones: v0.2.10, v0.x.x Apr 7, 2021
@gkjohnson
Copy link
Contributor Author

A simple implementation would just involve creating a sphere or box around the region volume.

@gkjohnson
Copy link
Contributor Author

From #269 (comment):

A region bounding volume is defined here:

https://github.com/CesiumGS/3d-tiles/tree/main/specification#region

It's a patch defined by a latitude, longitude, and height delta on the WGS 84 ellipsoid. A simple approach to supporting a region volume is to generate a sphere from the region coordinates so that can be used for frustum culling etc. That could be added here:

const region = null;
if ( 'region' in tile.boundingVolume ) {
console.warn( 'ThreeTilesRenderer: region bounding volume not supported.' );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant