Sequence Editor Followup

[duranb]

The following are some things that that we found from the sequence editor PR that were left out of the review in order to quickly push it through:

Tasks

Beta Give feedback

1. DictionaryTable.svelte - maintaining two different selections based multiselect can potentially become difficult to maintain consistent interactions. Refactor so that potentially only one list of selected IDs is maintained - Feature/seq editor cleanup #1338
2. The $parcel store should be a subscription to stay updated when other users update #1292
   +0
   
3. ArgumentTooltip.svelte - Confirm that for displays like arg.bit_length ?? 'None' the intent is to show 0 instead of None when the value is 0
4. ArgTitle.svelte - title should be set to variable that is set in a reactive statement to prevent unnecessary re-renders - set title in reactive statement #1304
5. NumEditor.svelte - input element should be of type number instead of string. - Feature/seq editor cleanup #1338
6. NumEditor.svelte - cleanup unused code - Feature/seq editor cleanup #1338
7. Repeat arg hovering doesn't trigger a tooltip in editor - Feature/seq editor cleanup #1338
8. Remove utils.ts as that was renamed to codemirror-utils.ts - Merge Sequence Editors Time library #1324
9. dictionaries/+page.svelte - the 'Adaptation' case can be changed to use the enum representation - Feature/seq editor cleanup #1338
10. Move sequencer-grammar-constants.ts to a new /constants directory for easier access across project
11. time-utils.ts - I don't think that the g flag is required for each of the regular expressions. Once those are removed, setting the regex.lastIndex would no longer be necessary. - Merge Sequence Editors Time library #1324
12. time-utils.ts - For isTimeBalanced, rather than passing the regex, can we just pass in defined type constants or enums (i.e. 'ABSOLUTE_TIME') so that the arguments are much more explicit - Merge Sequence Editors Time library #1324
13. Unify SeqN and TS eDSL Time Validator #1318
    sequencing +1
    
14. grammar.test.ts - update to be more understandable and less fragile @joswig? - Inline grammar tests #1303
15. Delete aerie-phoenix-wordmark.svg if not being used @joswig - Feature/seq editor cleanup #1338
16. permissions.ts - Rename permission for commandDictionary to generic dictionary if it's no longer command dictionary specific. (DELETE_COMMAND_DICTIONARY should be renamed as well if that's no longer relevant) - Feature/seq editor cleanup #1338
17. Prevent clicking on download/copy buttons when nothing is selected - Feature/seq editor cleanup #1338
18. Vertically align the "filter to my sequences" checkbox and text on the sequencing page - Feature/seq editor cleanup #1338
19. Style the editor tooltip for better legibility - Feature/seq editor cleanup #1338
20. Style the Selected Command section with proper header and Aerie components - Feature/seq editor cleanup #1338
21. Empty state for third column in sequence editor - Feature/seq editor cleanup #1338
22. Document usage of globalThis - Added an adaptation page, updated some of the content on the sequenci… aerie-docs#162
23. De-dupe and comment isTimeBalanced which can be found in both time-utils.ts and timeDiagnostics.ts - Merge Sequence Editors Time library #1324
24. More docstrings for time-utils.ts functions - Merge Sequence Editors Time library #1324
25. Able to uncheck a dictionary (and not select a new one) from a parcel, but saving doesn't persist. - Feature/seq editor cleanup #1338
26. Unify time formats across eDSL and SeqN.txt - Relative time is mismatched between the two editors - Merge Sequence Editors Time library #1324
27. Add unit test to verify time calculations are correct - Merge Sequence Editors Time library #1324
28. Add Sequence Adaptation name - Added names to sequence adaptations #1329
29. Disable save button in parcel form if user has not provided a parcel name - Feature/seq editor cleanup #1338
30. Prevent dictionary file upload re-submission during upload - Feature/seq editor cleanup #1338
31. Fix overflow on sequencing page when seq JSON view is collapsed (default). Causes nasty editor tooltip overflow resizing issues - Feature/seq editor cleanup #1338
32. The derived $parcel can still be theoretically undefined. I suggest we use find instead of filter and explicitly return null if it's not found - Feature/seq editor cleanup #1338

Optional Tasks

Beta Give feedback

1. fswCommandArgDefault in command-dictionary.ts can be in a switch statement - Feature/seq editor cleanup #1338
2. can we change queries like DELETE_PARCEL_TO_PARAMETER_DICTIONARIES to be more English friendly like DELETE_PARCEL_DICTIONARY_ASSOCIATION? - Feature/seq editor cleanup #1338

[joswig]

regarding the nullish coalescing on ArgumentTooltip, I'm good showing 'None' here, we can't safely infer a default if the value is unspecified in the dictionary. We could hide the row completely but that seems less obvious.

[duranb]

Closing this as most of the issues that were listed have been addressed. Opened a follow-up issue for anything remaining.