-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nssdca-delivery] urn:nasa:pds:insight_documents::2.0 and urn:nasa:pds:insight_hp3_tem::1.0 and urn:nasa:pds:insight_rad::2.1 and urn:nasa:pds:insight_rise_derived::1.0 and urn:nasa:pds:insight_rise_raw::2.0 and urn:nasa:pds:insight_seis::3.0 #511
Comments
The Geosceinces node is aware of the errors present in the validation reports for urn:nasa:pds:insight_documents::2.0 and urn:nasa:pds:insight:seis::3.0. We are not planning on correcting them at this time. |
@c-suh @jordanpadams Could you please hold off checking and posting this SIP LID?
I see extraneous data files in the SIP manifest. I highlighted those files in the attached XLS version of the manifest: The only files that should be listed in a PDS4 SIP manifest are: I have not see this for SIP manifests for ATM's Mars2020 MEDA bundle (https://pds-atmospheres.nmsu.edu/PDS/data/PDS4/Mars2020/mars2020_meda/bundle.xml). That bundle identifies several collections with secondary membership. To date, ATM has submitted it eight times and the manifests never included secondary collection products and their basic products. Could this have something to do with how a node generates the Deep Archive package, e.g., via local file system or via registry? Should I open a new ticket for Deep Archive for this case? Thanks. |
@smclaughlin7 yes. this is because they list them as secondary but have the files on the file system. we will have to file a ticket for this. @nutjob4life can you create a new ticket for this and investigate? I would work with @jshughes to understand more details about primary vs. secondary products/collections. |
@nutjob4life this may also be something we didn't think of with |
Hi @jordanpadams, my access to my laptop is restored (thanks JPL help desk—took about an hour) and I will set up the ticket. Reminder: I'm on vacation today through May 24th. |
@gbowen99 thank you for the note about the errors for documents 2.0 and seis 3.0. As @smclaughlin7 has requested, I have not posted the package for documents 2.0 but the other 4 sets have been posted for NSSDCA processing. From tomorrow, you can check the status at https://nssdc.gsfc.nasa.gov/psi/ReportPDS4.jsp using the SIP LIDs below: SIP LIDs:
For the last package for rise, there are a number of validate errors (see attached report). Please let me know if these are errors you will be addressing or ignoring, such as done with documents 2.0 and seis 3.0. Thank you. |
@c-suh sorry for the late response! I am a bit confused by the report you attached for the rise_raw dataset. Is that a validation report that you put together? The report I submitted for the bundle used validate 3.5.0-SNAPSHOT and doesn't have any errors present. Any idea what might be going on? |
Hi @gbowen99 - my apologies for the delay. Yes, the report that I attached above is one that I created. We ask the nodes to run the Validate tool with certain parameters, and then we at the Engineering node run the Validate tool again with different parameters. Since a new version of Validate was released last week, I did this again and see the same errors. I will check with our developers to make sure this isn't a bug on our part and will get back to you. Thank you for your patience! |
@gbowen99 this is an issue with our previous deep archive tool. If you have not already, please install the latest version, which has the bug fix for this error, to use that moving forward. For the problematic insight_rise_raw package, we will address the error then post this for NSSDCA processing; there is nothing more for you to do regarding this ticket for the time being (I expect documents 2.0 will go on another ticket after we implement the necessary functionality to the deep archive tool). Thank you! |
@c-suh @jordanpadams @gbowen99 Just an FYI --- The NSSDCA successfully ingested this SIP
But I'd like to note that the SIP manifest file contained 6 files for 3 extraneous, secondary product LIDs, due to a bug in the Deep Archive Tool when using the Registry to make the SIP:
Fortunately, our ingest process failed these products because their LIDs did not conform with the bundle product's LID, urn:nasa:pds:insight_rad. We suggessfully ingested all the other products in the SIP, so @gbowen99 does not need to generate and submit a new SIP for the InSight Rad Bundle v2.1. Yay! |
@smclaughlin7 @gbowen99 we will reprocess and resubmit these as soon as we have a fix to deep archive |
@jordanpadams On second thought, reprocessing and resubmitting these as soon as you have a fix to deep archive makes sense. Would help confirm deep archive is working a intended when it uses the Registry to build SIPs. Thanks!! |
Blocked by NASA-PDS/deep-archive#164, which is blocked by NASA-PDS/registry#185 |
@c-suh newly generated submission for insight_rad bundle: |
@jordanpadams Confirming that although the NSSDCA successfully ingested this SIP (for this case, ingest ignored the 3 extraneous, secondary product LIDs) |
@smclaughlin7 in that case, if this is good enough, we will move forward with other submissions and follow-up on this issue if it appears again. thanks for the heads up! |
@jordanpadams I recommend re-opening this ticket because the NSSDCA have not yet finished ingesting this SIP LID:
Thanks! |
@jordanpadams Thanks for reopening this ticket. Looking at the history above, we decided not to submit these two SIPs delivered via this ticket because we knew the manifest files contained extraneous secondary products: urn:nasa:pds:system_bundle:product_sip_deep_archive:insight_documents_v2.0_20240429 Is it OK for GEO (@alknight-wustl or @gbowen99) to generate and submit new Deep Archive packages for the InSight Documents and raw RISE bundles, or do you/EN want to do that? Thanks! |
@c-suh see the latest updated packages for all these SIPs for insight_rad, insight_documents, and insight_rise_raw here: insight_package.zip @smclaughlin7 I update the package to include both. |
@gbowen99 and @smclaughlin7 the 3 sets provided by Jordan have been posted for NSSDCA processing! From tomorrow, you can check the status at https://nssdc.gsfc.nasa.gov/psi/ReportPDS4.jsp using the SIP LIDs below: SIP LIDs: |
Discipline Node Information
Delivering Node: PDS Geosciences Node
NSSDCA Delivery Package:
GEO_InSight_delivery_packages_30_Apr_2024.zip
Validation report:
insight_validate_reports.zip
The text was updated successfully, but these errors were encountered: