Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the x-total-count header from the API specification #145

Closed
tloubrieu-jpl opened this issue Dec 22, 2021 · 3 comments
Closed

Remove the x-total-count header from the API specification #145

tloubrieu-jpl opened this issue Dec 22, 2021 · 3 comments
Assignees
Labels
B12.1 enhancement New feature or request

Comments

@tloubrieu-jpl
Copy link
Member

💪 Motivation

...it is not implemented to there no point having that.
In addfition, the specification itself is not finalized, see NASA-PDS/registry-api#565

📖 Additional Details

⚖️ Acceptance Criteria

Given
When I perform
Then I expect

⚙️ Engineering Details

@al-niessner
Copy link
Contributor

@jordanpadams @tloubrieu-jpl

Done. It is on swaggerhub as PDS-API-145 and is a branch of 0.5.0-SNAPSHOT. If I chose the wrong point to branch, then let me know and I will do it again from another starting point.

@gxtchen
Copy link

gxtchen commented Apr 23, 2022

@tloubrieu-jpl How and where can I verify it is removed?

@tloubrieu-jpl
Copy link
Member Author

Hi @gxtchen the specification is published on https://nasa-pds.github.io/pds-api/specifications.html , you are testing version 1.0.0.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.1 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants