Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to supply custom colormap #292

Open
justin-richling opened this issue Mar 19, 2024 · 1 comment
Open

Add option to supply custom colormap #292

justin-richling opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement New feature or request plotting Related to plot generation

Comments

@justin-richling
Copy link
Collaborator

New feature type

New plot and/or plot enhancement

What is this new feature?

Based on the nice work from @brianpm, having access to old NCL colormap .rgb files and code to generate matplotlib colomap objects, it seems very helpful to the user if they could supply a colormap file to use in the ADF.

In addition to .rgb files, .csv files can also be an option as matplotlib can build a colormap from those files as well.

These options will live in the adf_variable_defaults.yaml file under a new variable name like colormap_file.

Assistance required?

No, I will make a PR when the feature is ready

Extra info

No response

@justin-richling justin-richling added enhancement New feature or request plotting Related to plot generation labels Mar 19, 2024
@brianpm
Copy link
Collaborator

brianpm commented Mar 19, 2024

I like the idea of having this as a user option.

There are a bunch of conda-installable packages that have lot of good colormaps. Maybe we should consider adding one or more of those as (optional) dependencies? The poorly named colormaps (https://pratiman-91.github.io/colormaps/) has a lot. Palettable (https://jiffyclub.github.io/palettable/) also has a lot (but not the old NCL ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plotting Related to plot generation
Projects
None yet
Development

No branches or pull requests

2 participants