Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: mpif08 github action on pull request #563

Closed
hkershaw-brown opened this issue Oct 23, 2023 · 1 comment · Fixed by #576
Closed

Feature request: mpif08 github action on pull request #563

hkershaw-brown opened this issue Oct 23, 2023 · 1 comment · Fixed by #576
Assignees

Comments

@hkershaw-brown
Copy link
Member

Use case

We currently test nompi and mpi for pull requests using github actions.
https://github.com/NCAR/DART/blob/main/.github/workflows/action_on_pull_request.yml

job 1: no mpi

job 2: mpi

This feature request is for
New job 3: mpif08

Is your feature request related to a problem?

Increasing use of mpi_f08
This is an option you can (will be able to) compile dart with (#562) it would be good to catch when code changes break mpi or mpif08.
It is easy to miss changes in mpi/null/mpif08 because we have three very similar files - good candidate for a github action.

Describe your preferred solution

Add a job3 which builds with mpif08

  • runs simultaneously with Job 1 & Job 2 so does not add time to the pull request checks.
  • use-mpi is a boolean at the moment. This will need changing because we now have 3 mpi options.
  • will need to check that the dart dependencies container can run mpif08. If not, we'll need a new container.

Describe any alternatives you have considered

Testing by hand, but I've already failed at that (see https://github.com/NCAR/DART/actions/runs/6617835818/job/17974993187)

@hkershaw-brown
Copy link
Member Author

Also an observation converter - add as separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants