NCL_axes_3.py

[hCraker]

Closes #310

[hCraker]

[hCraker]

It is an extremely small detail, but I noticed that gvutil.add_major_minor_ticks sets the value of the minor tick mark to be 5.5e2 for the top right plot and 5.5e1 and 5.5e2 for the lower left one. It's not an issue for this example, but it is an error in that function since the value should be 5e2. I will be opening a PR in geocat-viz to fix it.

[anissa111]

This looks good, but I noticed you're using a different comment style than previous examples, like on line 41:

##### Create plot with linear axes and full perimeter #####.

Is there a reason that you've formatted them like this?

[hCraker]

This looks good, but I noticed you're using a different comment style than previous examples, like on line 41:

##### Create plot with linear axes and full perimeter #####.

Is there a reason that you've formatted them like this?

@anissa111 I did this to make it very clear when looking at the code when I'm making one subplot versus another. Let me know if you have a better way of making this distinction. It's purely for readability.

[anissa111]

I understand why you've included the different comment style, but I think it should be altered to closer match the style of existing comments.

Do you think it would be okay to do something like
# Subplot (1, 1): Create plot with linear axes and full perimeter
would work?

I looked into modifying how the Sphinx RTD image scrapers work to allow for sectioning with the markdown sectioning, but it doesn't look very promising.

[anissa111]

Thank you for making that change!