Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should MARBL abort when mass balance checks fail? #1

Closed
mnlevy1981 opened this issue Jan 12, 2016 · 2 comments
Closed

Should MARBL abort when mass balance checks fail? #1

mnlevy1981 opened this issue Jan 12, 2016 · 2 comments
Assignees
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

We compute 100m vertical integrals in cases where we also compute the full-depth vertical integral and expect the latter to be 0 to round-off level... instead of returning these integrals as diagnostics, should MARBL check to make sure the full-depth integral is less than some threshold and error out if the threshold is exceeded?

@mnlevy1981 mnlevy1981 modified the milestone: Open Discussions Jan 24, 2017
@matt-long matt-long changed the title Do we need 100m diagnostic integrals? Should MARBL abort when mass balance checks fail? Jan 24, 2017
@mnlevy1981
Copy link
Collaborator Author

Note that at this time, CISO_Jint_14Ctot does not account for radiocarbon decay, so we don't expect it to be 0 (and it's not)

@mnlevy1981
Copy link
Collaborator Author

fixed in marbl0.28.1

kristenkrumhardt referenced this issue in kristenkrumhardt/MARBL Jul 23, 2018
jessluo added a commit to jessluo/MARBL that referenced this issue Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants