You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way MARBL_tools:MARBL_settings_class determines tracer count assumes the user is running with PFT_defaults = 'CESM2'. This is fine for running out of the box, but causes problems when PFT_defaults = 'user-specified' and will also be problematic in the future when we try to implement tiered complexities.
The problem stems from this block of code in the YAML:
To start with, we need to allow multiple defaults depending on PFT_defaults so the above values are only captured if PFT_defaults = 'CESM2'. We also need to offer the user a way to change in via input file (such as letting a CESM user put _tracer_cnt = 54 in user_nl_marbl); that will require hard-coding a check for _tracer_cnt in input_dict before processing the tracer_dependent category.
Following the above recomendation, the default should be _tracer_cnt = -1 if PFT_defaults = 'user-specified' and then we can abort if the user does not change the tracer count to a positive value.
The text was updated successfully, but these errors were encountered:
The way
MARBL_tools:MARBL_settings_class
determines tracer count assumes the user is running withPFT_defaults = 'CESM2'
. This is fine for running out of the box, but causes problems whenPFT_defaults = 'user-specified'
and will also be problematic in the future when we try to implement tiered complexities.The problem stems from this block of code in the YAML:
To start with, we need to allow multiple defaults depending on
PFT_defaults
so the above values are only captured ifPFT_defaults = 'CESM2'
. We also need to offer the user a way to change in via input file (such as letting a CESM user put_tracer_cnt = 54
inuser_nl_marbl
); that will require hard-coding a check for_tracer_cnt
ininput_dict
before processing thetracer_dependent
category.Following the above recomendation, the default should be
_tracer_cnt = -1
ifPFT_defaults = 'user-specified'
and then we can abort if the user does not change the tracer count to a positive value.The text was updated successfully, but these errors were encountered: