Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match code to lapply_nhx_surface_emis name and description #248

Closed
klindsay28 opened this issue Mar 19, 2018 · 1 comment
Closed

match code to lapply_nhx_surface_emis name and description #248

klindsay28 opened this issue Mar 19, 2018 · 1 comment
Labels
quick fix Issues that can be clumped into a "low-hanging fruit" pull request
Milestone

Comments

@klindsay28
Copy link
Collaborator

klindsay28 commented Mar 19, 2018

Pull request #162 changed the name and description of the setting related to nhx surface emissions. The new settings name is lcompute_nhx_surface_emis and the description is
"control if NHx emissions are computed".

However, the flag doesn't control if the emissions are computed.
It still controls if NHx emissions are subtracted from stf(:,nh4_ind).
The code should be changed to match the setting's name and description.
If the flag is .false., then the emissions should not be computed (or subtracted from stf).

@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Mar 20, 2018
@mnlevy1981 mnlevy1981 added the quick fix Issues that can be clumped into a "low-hanging fruit" pull request label Mar 21, 2018
@mnlevy1981
Copy link
Collaborator

closed in marbl0.28.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick fix Issues that can be clumped into a "low-hanging fruit" pull request
Projects
None yet
Development

No branches or pull requests

2 participants