Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate and correct units for DUST_FLUX, IRON_FLUX, etc. #63

Closed
klindsay28 opened this issue May 12, 2016 · 2 comments
Closed

investigate and correct units for DUST_FLUX, IRON_FLUX, etc. #63

klindsay28 opened this issue May 12, 2016 · 2 comments
Assignees
Milestone

Comments

@klindsay28
Copy link
Collaborator

code has comment

    ! multiply DUST flux by mpercm (.01) to convert from model units (cm/s)(mmol/m^3) to mmol/s/m^2

This is can't be correct, because DUST_FLUX has units g/cm^2/s.

@mnlevy1981 mnlevy1981 modified the milestone: Feature-complete API May 19, 2016
@mnlevy1981
Copy link
Collaborator

This comment is still in marbl_diagnostics_mod.F90

@mnlevy1981
Copy link
Collaborator

DUST_FLUX is definitely coming in from the GCM as g/cm^2/s, which are already the units for DUST_FLUX and dustToSed. We want to change the units for DUST_FLUX_IN to be the same, and no need to multiply any dust diagnostics by mpercm.

dust_REMIN should be g/cm^3/s (and also we should output dust%remin rather than P_SiO2%remin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants