Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MET to compile using PGI version 20. #1317

Closed
5 of 18 tasks
JohnHalleyGotway opened this issue Apr 28, 2020 · 2 comments · Fixed by #1787
Closed
5 of 18 tasks

Fix MET to compile using PGI version 20. #1317

JohnHalleyGotway opened this issue Apr 28, 2020 · 2 comments · Fixed by #1787
Assignees
Labels
component: build process Build process issue priority: medium Medium Priority requestor: Community General Community type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 28, 2020

Describe the Task

As reported by a user via met-help (https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=95051), met-9.0.1 does not compile using the PGI version 19 compilers. The compilation error is in the vx_nc_obs library:

1 catastrophic error detected in the compilation of "nc_obs_util.cc".
Compilation aborted.
pgc++-Fatal-/usr/local/pgi/linux86-64-nollvm/19.10/bin/pggpp1 TERMINATED by signal 6

Julie Prestopnik tested using PGI 19.9 on Cheyenne and was able to replicate this compilation error. This task is to update met-9.1 to once again compile using the PGI compilers.

You can find the test environment on cheyenne in /glade/p/ral/jntp/MET/MET_cross_platform_testing/met-9.0.1/pgi

Ideally, we could automate the testing of MET using PGI compilers via Docker containers, but there would likely be issues with the PGI license file.

Time Estimate

1 day.

Sub-Issues

Consider breaking the task down into sub-issues.

  • No sub-issues required. I expect this to only require a small number of changes.

Relevant Deadlines

None

Funding Source

2760811

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required - no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the task and verify your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: build process Build process issue type: task An actionable item of work priority: medium Medium Priority requestor: Community General Community alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Apr 28, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1 milestone Apr 28, 2020
@jprestop
Copy link
Collaborator

Bart Brashers, who submitted the met-help ticket referenced in the issue, is willing to help test a PGI fix.

@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label May 4, 2020
@JohnHalleyGotway JohnHalleyGotway modified the milestones: MET 9.1, MET 10.0 Jun 8, 2020
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Sep 10, 2020
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Nov 5, 2020
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Feb 16, 2021
@jprestop jprestop added alert: NEED ACCOUNT KEY Need to assign an account key to this issue and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Feb 18, 2021
@jprestop jprestop changed the title Fix MET to compile using PGI version 19. Fix MET to compile using PGI version 20. Apr 19, 2021
@jprestop
Copy link
Collaborator

Compiling with PGI version 19 is still problematic, however MET an its required external libraries compile well with PGI version 20.4. This compilation was tested on Cheyenne at /glade/p/ral/jntp/MET/MET_cross_platform_testing/met-10.0.0-beta4/pgi.

@JohnHalleyGotway JohnHalleyGotway linked a pull request May 10, 2021 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process Build process issue priority: medium Medium Priority requestor: Community General Community type: task An actionable item of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants