Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fractional stoichiometric coefficients for reactants #595

Closed
K20shores opened this issue Jul 8, 2024 · 1 comment
Closed

Support fractional stoichiometric coefficients for reactants #595

K20shores opened this issue Jul 8, 2024 · 1 comment

Comments

@K20shores
Copy link
Collaborator

During #593, the oregonator and e5 analytical tests were converted to pure reactions so that they could be tested on the GPU.

The equations for HIRES were also derived and placed into the comments for that test. However, it requires fractional coefficients on the reactant side which we don't yet support. Support them.

Acceptance criteria

  • The HIRES test is build from the set of equations and runs on CPU (Jit and regular), and GPU

Ideas

@K20shores K20shores added this to the MICM, TUV-x in CAM-SIMA milestone Jul 8, 2024
@K20shores
Copy link
Collaborator Author

Well, that was completely inaccurate. All of the fractional yields are on the right.

@K20shores K20shores closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant