Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Yerror construction outside of the inner solve loop for rosenbrock #622

Closed
Tracked by #211
K20shores opened this issue Aug 9, 2024 · 0 comments · Fixed by #652
Closed
Tracked by #211

Move Yerror construction outside of the inner solve loop for rosenbrock #622

K20shores opened this issue Aug 9, 2024 · 0 comments · Fixed by #652
Assignees
Labels
good first issue Good for newcomers

Comments

@K20shores
Copy link
Collaborator

K20shores commented Aug 9, 2024

Yerror is constructed in the innermost loop of rosenbrock. For GPU, this means we are constantly allocating and deallocating memory on the hot path

MatrixPolicy Yerror(num_rows, num_cols, 0);

Acceptance criteria

  • Yerror is only constructed once and reused for the all iterations of rosenbrock
  • Yerror is set to zero before the error is calculated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants