Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File format should be mandatory #7

Closed
davidhassell opened this issue Apr 20, 2021 · 1 comment
Closed

File format should be mandatory #7

davidhassell opened this issue Apr 20, 2021 · 1 comment
Labels

Comments

@davidhassell
Copy link
Collaborator

No description provided.

@davidhassell
Copy link
Collaborator Author

davidhassell commented Apr 21, 2021

Given that the format should be mandatory if the file variable exists, I think that it makes sense for all terms to be mandatory: location (already was), file, format, address. The only case when address could be omitted was if all of the data was undefined (e.g, an entire aggregated array of missing data), which is pretty unlikely.

Making all four terms mandatory is much cleaner, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant