Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inferred Edge Should Match Fully Qualified Query Graph Edge - MVP2 #855

Closed
sstemann opened this issue Jul 11, 2024 · 10 comments
Closed

Inferred Edge Should Match Fully Qualified Query Graph Edge - MVP2 #855

sstemann opened this issue Jul 11, 2024 · 10 comments
Assignees
Labels
Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) predicate pattern indicate a specific predicates chain question Further information is requested

Comments

@sstemann
Copy link

I dont fully understand why the predicates differ so frequently, when I read them in the UI, I'm not sure I understand how substantially different to the reasoned answer

"Tamoxifen Causes Decreased Activity Or Abundance Of Arid1a" vs "Tamoxifen Affects Decreased Activity Or Abundance Of Arid1a"

then the more general "Tamoxifen Affects Arid1a"

image

https://ui.test.transltr.io/main/results?l=ARID1A%20(Human)&i=NCBIGene:8289&t=2&r=0&q=1d650508-5292-4faf-a52c-21954c89fb36

When I look at it in the ARAX GUI
ARAGORN

  • Lookup via TMKP
image
  • Inferred via Prediction - Affects Decreased Activity Or Abundance Of
image

The support graph of the prediction - looks to be a TMKP lookup
image

ARAX

  • lookup via TMKP
image

BTE

  • lookup via TMKP
image
  • the other edge is inferred, prediction Affects
image

all but one of these SG edges are TMKP
image

Unsecret

  • lookup via TMKP
image
  • Inferred 1 - Causes Decreased Activity Or Abundance Of
image
  • Inferred 2 - Causes Decreased Activity Or Abundance Of
image
@sstemann sstemann added question Further information is requested biolink predicate pattern indicate a specific predicates chain labels Jul 11, 2024
@sstemann
Copy link
Author

@sierra-moxon i'm not sure if any one thing is actually wrong here, but do you have guidance?

@sierra-moxon
Copy link
Member

I believe these are all the same result and need to be merged.

How do we get to a merge?

  • @cbizon - do you know why the inferred edges here do not have qualified_predicate: biolink:causes?

In the back of my mind, it seems a little odd that we have inferred edges that seem to be just reiterating the lookup edges. Am I misunderstanding these results?

@sierra-moxon sierra-moxon assigned cbizon and unassigned sierra-moxon Jul 11, 2024
@sierra-moxon sierra-moxon added the needs review this ticket needs a broad group of people to review and assign next steps because it crosses teams label Jul 11, 2024
@sierra-moxon sierra-moxon self-assigned this Jul 11, 2024
@sierra-moxon sierra-moxon added the Guppy (Sprint 5) - due Aug 23 in CI This ticket will be fixed in CI by the end of Guppy (Sprint 5) (Aug 23) label Jul 11, 2024
@sstemann
Copy link
Author

i believe ARS treats these edges as unique and doesnt merge them but defer to @MarkDWilliams @gprice1129

@gprice1129
Copy link
Collaborator

gprice1129 commented Jul 23, 2024

The predicate variation (especially Affects Decreased Activity Or Abundance Of) seems to be a mistake from the ARA/KP. We will look into why the edges in the first screenshot are not being compressed.

@dnsmith124
Copy link
Collaborator

After reviewing the pk again in the UI the edges in the first screenshot are now being properly compressed

@sstemann
Copy link
Author

i see some compression but i dont particularly understand how these are substantially different that they need to be displayed this way (my question my really be - do the ARAs really have different intentions here or are they just non-standardized for some other reason)?

image

@sierra-moxon
Copy link
Member

sierra-moxon commented Jul 26, 2024

from TAQA:
lets try this in CI and see if it works - we think BTE was fixed to use the qualified_predicate in the query. e.g. we think BTE, Aragorn will respond to a query with qualified_predicate (but we need to test via ARAX and make sure no ARAs are always left out).

then we need the UI to pass the qualified_predicate to the ARs.

Sui: too many predicates saying the same thing, eg "chemical affects expression of x" - gets mapped differently in the UI? In two-hop answers, we have down and up-regulated (can mean expression, activity, etc), a-upregulates-b- upregulates-c)

@sierra-moxon sierra-moxon removed needs review this ticket needs a broad group of people to review and assign next steps because it crosses teams biolink labels Jul 26, 2024
@colleenXu
Copy link

colleenXu commented Aug 11, 2024

For BTE:

  • as described here, BTE should now be able to accept queries with qualified_predicate set in Fugu.
  • we now have a fix on CI to set the inferred edge qualifier set correctly

@sstemann sstemann changed the title MVP2 - Predicates in results Inferred Edge Should Match Fully Qualified Query Graph Edge - MVP2 Aug 16, 2024
@sierra-moxon
Copy link
Member

retested on CI today, far fewer predicates, more merging. did not spend too long evaluating results but the original issue to me, is fixed.

@sstemann sstemann added Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) and removed Guppy (Sprint 5) - due Aug 23 in CI This ticket will be fixed in CI by the end of Guppy (Sprint 5) (Aug 23) labels Aug 30, 2024
@sstemann
Copy link
Author

this is in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) predicate pattern indicate a specific predicates chain question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants