Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate sample name and sample title fields in UI #25

Closed
FullyWashable opened this issue Mar 1, 2016 · 4 comments
Closed

Populate sample name and sample title fields in UI #25

FullyWashable opened this issue Mar 1, 2016 · 4 comments
Assignees

Comments

@FullyWashable
Copy link
Collaborator

I don't know if these are populated in the core, but they are empty in the actual app right now.

@eweitz
Copy link
Collaborator

eweitz commented Mar 1, 2016

@lepons, I won't have easy access to the annotation Solr core until tonight, but if I recall correctly, sample name and sample title are not populated there. Could you populate those fields?

@lepons
Copy link
Contributor

lepons commented Mar 1, 2016

Looking at the annotation Solr core, I see that there are samples that have
sampleName and sampleTitle populated:

There are about 3420 or so samples with sampleName and maybe 114 with
sampleTitle populated, and it's consistent with what's in AnnotationsDev.
So I think the data is consistent with what was pulled from BioSample, it's
just that field is frequently missing.

[image: Inline image 1]

[image: Inline image 2]

On Tue, Mar 1, 2016 at 1:35 PM, Eric Weitz notifications@github.com wrote:

@lepons https://github.com/lepons, I don't have easy access to the
annotation Solr core, but if I recall correctly, sample name and sample
title are not populated there. Could you populate those fields?


Reply to this email directly or view it on GitHub
#25 (comment)
.

@eweitz
Copy link
Collaborator

eweitz commented Mar 1, 2016

OK, thanks for the correction. I'll update the web backend and UI to pull in those values from the Solr datastore.

@eweitz
Copy link
Collaborator

eweitz commented Mar 3, 2016

It turns out that sample name and sample title are already populated in the UI, as well. As @lepons notes, only a very small fraction of records have values for these fields in the underlying Solr core. So if this is an issue, it seems to be with the underlying BioSample data.

If on our network and tunneled into the Solr core on EC2, here's how to verify things are working as expected:

Sample name

Sample title

Given this, I'll close this ticket for now. The underlying BioSample data issue may warrant more investigation, but that seems like a separate issue, as the data is being populated in the UI.

@eweitz eweitz closed this as completed Mar 3, 2016
@eweitz eweitz self-assigned this Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants