Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warning from qa_package #182

Open
dmullen17 opened this issue Dec 13, 2018 · 0 comments
Open

remove warning from qa_package #182

dmullen17 opened this issue Dec 13, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmullen17
Copy link
Member

Discussed with @jagoldstein about removing the following warning from qa_package. Integers are used to represent nominal values far more often than characters.

if (matchingAtt$measurementScale != "ratio" && matchingAtt$measurementScale != "interval" && matchingAtt$measurementScale != "dateTime") {
                    cat(crayon::yellow(paste0("\nMismatch in attribute type for the attribute '", matchingAtt$attributeName,
                                              "'. Type of data is ", attClass, " which should probably have interval or ratio measurementScale in EML, not ",
                                              matchingAtt$measurementScale, ".")))

The two checks following this one (lines 480-497) could also be removed

@dmullen17 dmullen17 self-assigned this Dec 13, 2018
@jagoldstein jagoldstein added the enhancement New feature or request label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants