Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling citation not showing up in view service #31

Closed
amoeba opened this issue Feb 16, 2018 · 5 comments
Closed

Sampling citation not showing up in view service #31

amoeba opened this issue Feb 16, 2018 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amoeba
Copy link
Contributor

amoeba commented Feb 16, 2018

@isteves noticed this over in NCEAS/metacatui#485 that the sampling citation isn't showing up for this document:

https://arcticdata.io/catalog/#view/doi:10.18739/A2C857

as shown by this:

36182580-3292080e-10df-11e8-9b74-b86206f058dc

I'm not sure why this is, though I did look at the eml2- XSLs and it looks like this should work. There's a citation template in eml-literature.xsl but I haven't looked into why this information isn't showing up.

@amoeba amoeba added the bug Something isn't working label Feb 16, 2018
@taojing2002 taojing2002 added this to the 2.15.0 milestone Feb 12, 2021
@taojing2002 taojing2002 modified the milestones: 2.15.0, 2.16.0 Mar 24, 2021
@taojing2002 taojing2002 modified the milestones: 2.16.0, 2.17.0 Dec 15, 2021
@taojing2002 taojing2002 modified the milestones: 2.17.0, 2.18.0 Mar 21, 2022
@taojing2002 taojing2002 modified the milestones: 2.18.0, 2.19.0 Nov 7, 2022
@taojing2002 taojing2002 modified the milestones: 2.19.0, 3.0.0 Dec 1, 2022
@artntek artntek self-assigned this Jan 31, 2023
@artntek artntek modified the milestones: 3.0.0, 2.19.0 Jan 31, 2023
@artntek
Copy link
Contributor

artntek commented Feb 1, 2023

This is the response snippet received by metacatui from metacat:

    <div class="control-group">
        <label class="control-label">Sampling Citation</label>
        <div class="controls">
            <cite xmlns="http://purl.org/dc/terms/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
                  xmlns:dcx="http://ns.dataone.org/metadata/schema/onedcx/v1.0" 
                  xmlns:dct="http://purl.org/dc/terms/" class="citation" />
        </div>
    </div>
    <div class="control-group">
        <label class="control-label">Sampling Citation</label>
        <div class="controls">
            <cite xmlns="http://purl.org/dc/terms/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
                  xmlns:dcx="http://ns.dataone.org/metadata/schema/onedcx/v1.0" 
                  xmlns:dct="http://purl.org/dc/terms/" class="citation" />
        </div>
    </div>

whereas the sampling section should contain 2 citations:

        <citation>
          <title>Measured basal water pressure variability of the western Greenland Ice 
                            Sheet: Implications for hydraulic potential</title>
[...content removed for clarity...]
        <citation>
          <title>Measured horizontal temperature gradients contrain heat transfer 
                           mechanisms in Greenland ice</title>
[...etc]

@artntek
Copy link
Contributor

artntek commented Feb 2, 2023

lib/style/skins/metacatui/metacatui.xsl imports two different versions of an xsl template named "citation" (in lib/style/skins/metacatui/eml-2/eml-literature.xsl and lib/style/skins/metacatui/fgdc/fgdc-root.xsl), and because the one in fgdc-root.xsl is imported last, it overwrites the one in eml-literature.xsl, which is what causes the non-displaying Sampling Citation section.

@artntek
Copy link
Contributor

artntek commented Feb 2, 2023

fixing the import ordering makes some of the Sampling Citation info show up, but not all of it. Comparing to display in Morpho, the same info is missing, so I'm wondering if it has ever shown up correctly? Will continue to investigate...

Sampling Citation info that should be listed:

  • title
  • creator
  • pubDate
  • article

Sampling Citation info that is listed after xsl:import fix (metacatui):

  • article

SamplingCitation_metacatui

Sampling Citation info that is listed in morpho:

  • article

SamplingCitation_morpho

@artntek
Copy link
Contributor

artntek commented Feb 2, 2023

metadata is not displaying because several imports have been commented out in various xsl files. Uncommenting them leads to a circular import and a crash - which is probably why they're commented out in the first place.

root is:

lib/style/skins/metacatui/metacatui.xsl

Sampling template is in:

lib/style/skins/metacatui/eml-2/eml-method.xsl

for-each select="citation" hands off to citation template in:

lib/style/skins/metacatui/eml-2/eml-literature.xsl
...which in turn hands off to the citationCommon template in the same file

citationCommon TRIES to hand off to a resource template,

but the xsl:import in: lib/style/skins/metacatui/eml-2/eml-resource.xsl has been commented out:
<!--<xsl:import href="eml-resource.xsl"/>-->

and in eml-resource.xsl, the following imports are commented out:

<!--<xsl:import href="eml-party.xsl"/>
  <xsl:import href="eml-distribution.xsl"/>
  <xsl:import href="eml-coverage.xsl"/>-->

uncommenting them leads to an exception, because eml-coverage.xsl has a circular import back to:
<xsl:import href="eml-literature.xsl"/>

The plot thickens...

@artntek
Copy link
Contributor

artntek commented Feb 8, 2023

fixed in #1605

@artntek artntek closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants