Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species With BOTH Shrub & Tree Habit? #129

Open
blcampbell opened this issue May 20, 2019 · 3 comments
Open

Species With BOTH Shrub & Tree Habit? #129

blcampbell opened this issue May 20, 2019 · 3 comments
Assignees
Labels
data issue Issue lies in the underlying data instead of the application or database structure/functionality

Comments

@blcampbell
Copy link
Contributor

This is a follow-on data check from #103 to see if there are any situations where we were either missing the habit value or there is a mismatch since the value had previously been set by the user. As a result of that check, it became clear that a check on tlu_Plants was also warranted (the same species was listed as a shrub for one record an tree for another).

Several species are setup in tlu_Plants to have both the Tree AND Shrub habit.

@lizmatthews03, @johnpauls, @abrolis
Please check if all of the species listed SHOULD be setup as having BOTH habits (both tree and shrub).

All species In the list below have both Tree and Shrub set as habits. All appear as a Tree in the habit dropdown on the saplings tab (since all are marked as Tree and the underlying code looks for trees first, they all appear as Tree)

TSN Latin_Name
18042 Cupressaceae Family
19038 Ulmaceae Family
19358 Quercus ilicifolia
19465 Betulaceae Family
22528 Salix eriocephala
22546 Salix humilis
22554 Salix lucida
23463 Ericaceae Family
24538 Rosaceae Family
24763 Prunus americana
24768 Prunus angustifolia
24774 Prunus domestica
24806 Prunus virginiana
25108 Amelanchier spp.
25296 Pyrus pyrifolia
26198 Robinia viscosa
28773 Rhus copallina
28823 Toxicodendron vernix
28989 Poncirus trifoliata
28992 Ptelea trifoliata
32927 Oleaceae Family
194883 Taxus baccata
194886 Taxus cuspidata
500059 Fabaceae Family
505297 Sorbus hybrida
999999 Unknown

Since #103 has been automated, it is important that this aspect is corrected at the same time to avoid data that requires fixing moving forward.

@blcampbell blcampbell added the data issue Issue lies in the underlying data instead of the application or database structure/functionality label May 20, 2019
@blcampbell blcampbell added this to the 2019 Pre-Season Updates milestone May 20, 2019
@blcampbell blcampbell self-assigned this May 20, 2019
@lizmatthews03
Copy link

lizmatthews03 commented May 21, 2019 via email

@blcampbell
Copy link
Contributor Author

Since the last note on unknowns states:
"for the same reason that we should treat low resolution taxa as Trees, I think Unknown should default to Tree"

Clarifying:
What I'm looking for is whether these species should have both their Tree and Shrub flags in tlu_Plants changed to being only Tree or only Shrub.

The application already accommodates those which are set as both Shrub & Tree in tlu_Plants by defaulting them to Tree in the sapling Habit dropdown.

@lizmatthews03 please confirm:

With this clarification are there any changes for the tlu_Plants flags from what you've noted above?

tlu_Plants Changes
Based on species adjustments noted above, tlu_Plants flags will be adjusted as follows...

  • Shrub - set Shrub flag only
  • Tree - set Tree flag only
  • Both - no change

Sapling Habit Dropdown Behavior
The application will continue to handle habits based on the tlu_Plant Tree and Shrub flags, defaulting those which have both checked to Tree in the dropdown. Species where only Shrub is checked in tlu_Plants will default to Shrub.

A user can still select Shrub (or Tree) for any species. So while these default based on tlu_Plants they do not fully restrict a user from making an incorrect - or correct - choice (based on tlu_Plants).

Data Alignment
Overall, sapling data should be congruent and match with tlu_Plants flags. There shouldn't be a situation where the habit flag for a sapling is set to a flag that doesn't match with the species' Tree/Shrub flags in tlu_Plants.

Instances where habit is either unclear (i.e. could be Tree or Shrub) or potentially could be either Tree or Shrub should probably remain set with both Tree and Shrub flags in tlu_Plants.

@lizmatthews03
Copy link

Using the three categories described above, I've updated the actions for each TSN Latin_Name currently in tlu_Plants with both Tree and Shrub flags. (This is consistent with the content in my previous comment, but hopefully clearer and easier to interpret!)

18042 Cupressaceae Family --both (no change)
19038 Ulmaceae Family --both (no change)
19358 Quercus ilicifolia -- Shrub - set Shrub flag only
19465 Betulaceae Family --both (no change)
22528 Salix eriocephala -- Shrub - set Shrub flag only
22546 Salix humilis --Shrub - set Shrub flag only
22554 Salix lucida --Shrub - set Shrub flag only
23463 Ericaceae Family --both (no change)
24538 Rosaceae Family --both (no change)
24763 Prunus americana -- Shrub - set Shrub flag only
24768 Prunus angustifolia -- Shrub - set Shrub flag only
24774 Prunus domestica --Tree - set Tree flag only
24806 Prunus virginiana -- Shrub - set Shrub flag only
25108 Amelanchier spp. --Tree - set Tree flag only
25296 Pyrus pyrifolia --Tree - set Tree flag only
26198 Robinia viscosa --Tree - set Tree flag only
28773 Rhus copallina --Tree - set Tree flag only
28823 Toxicodendron vernix -- Shrub - set Shrub flag only
28989 Poncirus trifoliata -- Shrub - set Shrub flag only
28992 Ptelea trifoliata -- Shrub - set Shrub flag only
32927 Oleaceae Family --both (no change)
194883 Taxus baccata --Tree - set Tree flag only
194886 Taxus cuspidata --Tree - set Tree flag only
500059 Fabaceae Family --both (no change)
505297 Sorbus hybrida --Tree - set Tree flag only
999999 Unknown --both (no change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data issue Issue lies in the underlying data instead of the application or database structure/functionality
Projects
None yet
Development

No branches or pull requests

2 participants