Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic text for twitter embed #70

Closed

Conversation

akshajb
Copy link

@akshajb akshajb commented Oct 16, 2021

Added dynamic text for twitter share on each section.

@encody
Copy link
Member

encody commented Oct 18, 2021

Although this updates the tweet text with content that matches the shared link, the shared link is still incorrect. If I load /leaderboards, and then navigate to /overview, and then click the Tweet button, it still shares the /leaderboards link even though I was on /overview.

@akshajb
Copy link
Author

akshajb commented Oct 18, 2021

Although this updates the tweet text with content that matches the shared link, the shared link is still incorrect. If I load /leaderboards, and then navigate to /overview, and then click the Tweet button, it still shares the /leaderboards link even though I was on /overview.

I was only able to check it on my local and felt it was not updating because of all the errors that are coming up in the console. the URL does change if you refresh the page. Is it the same issue on live as well ?

@encody
Copy link
Member

encody commented Oct 18, 2021

@akshajb Oh, do you have the server set up on your local?

@akshajb
Copy link
Author

akshajb commented Oct 18, 2021

@akshajb Oh, do you have the server set up on your local?

i just followed the steps for the frontend i am assuming.

@encody
Copy link
Member

encody commented Oct 18, 2021

@akshajb The frontend needs a backend to communicate with to work properly. Let me know if you need any help setting it up.

@akshajb
Copy link
Author

akshajb commented Oct 18, 2021

No problems, Let me look at the server repo, and try to set that up. The only query i have is, once i find the bug and am able to fix it, I create a new PR right ?

@encody
Copy link
Member

encody commented Oct 18, 2021

You can add commits to this PR

@akshajb
Copy link
Author

akshajb commented Oct 18, 2021

Thank you

@akshajb
Copy link
Author

akshajb commented Oct 30, 2021

@encody I am using WSL as my dev env and have postgres installed. I was not able to import the sql dump though. I might need some help to get the server set up.

@akshajb
Copy link
Author

akshajb commented Oct 30, 2021

When I try to import the file into the database that I created I get the following error.
image

@encody
Copy link
Member

encody commented Oct 30, 2021

Oops, I ran the export with incorrect settings. I'll get that fixed soon, although I am not able to right now. Thanks for pointing this out.

@encody
Copy link
Member

encody commented Nov 9, 2021

Closing for inactivity.

@encody encody closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants