Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the text and link for the twitter share dynamic #72

Merged
merged 8 commits into from
Nov 10, 2021

Conversation

ImTheCodeFarmer
Copy link
Contributor

@ImTheCodeFarmer ImTheCodeFarmer commented Nov 9, 2021

image

image

In this PR, both the link and text are dynamic.

@encody
Copy link
Member

encody commented Nov 9, 2021

Part of the issue is that the Twitter button code actually replaces the HTML in the page with an <iframe>, so the computed properties don't update on page navigation because the target element no longer exists (i.e. it has been replaced with Twitter's custom code). One solution to this problem would be to replace this code with a dynamically re-generated bit of HTML code that we stick into a v-html binding, and then re-run the Twitter button replacer code.

@ImTheCodeFarmer
Copy link
Contributor Author

@encody I have updated this to rerender on route change.

src/views/Page.vue Outdated Show resolved Hide resolved
src/views/Page.vue Outdated Show resolved Hide resolved
src/views/Page.vue Outdated Show resolved Hide resolved
src/views/Page.vue Outdated Show resolved Hide resolved
@encody
Copy link
Member

encody commented Nov 9, 2021

The Tweet button does not appear when loading the overview page from the landing page.

2021-11-09-16-02-51

src/views/Page.vue Outdated Show resolved Hide resolved
src/views/Page.vue Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ImTheCodeFarmer ImTheCodeFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been made and committed to this branch.

@encody encody merged commit 1c64c88 into NEARFoundation:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants