Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing scenes causes error #86

Closed
TimPietrusky opened this issue Oct 4, 2018 · 1 comment
Closed

Removing scenes causes error #86

TimPietrusky opened this issue Oct 4, 2018 · 1 comment
Labels
bug released
Projects
Next

Comments

@TimPietrusky
Copy link
Member

Issue description

When removing a scene an error is thrown in scene-list-item:

// Cannot read property 'name' of undefined

    return html`
      <div>
        ${scene.name}
      </div>
    `;

Steps to reproduce

  • Add scene A
  • Remove scene A

Versions

  1. Browser: Chrome 69
  2. luminave: 3.0.0
@TimPietrusky TimPietrusky added this to To do in Next via automation Oct 4, 2018
@TimPietrusky TimPietrusky moved this from To do to In progress in Next Oct 9, 2019
TimPietrusky added a commit that referenced this issue Oct 11, 2019
@TimPietrusky
fix(scene): Remove scene causes no error anymore
96a152c 
fix #86
@TimPietrusky TimPietrusky mentioned this issue Oct 11, 2019
Merged
Next automation moved this from In progress to Done Oct 11, 2019
TimPietrusky pushed a commit that referenced this issue Oct 11, 2019
@semantic-release-bot
chore(release): 3.6.1 [skip ci]
f8eba28 
## [3.6.1](v3.6.0...v3.6.1) (2019-10-11)

### Bug Fixes

* **animation:** Don't reset the scene when animation is done ([4866618](4866618)), closes [#112](#112)
* **animation:** Remove animation from venue ([950a21e](950a21e)), closes [#85](#85)
* **fixture:** Remove fixture from scene and venue ([5ce5d6f](5ce5d6f)), closes [#83](#83)
* **scene:** Remove scene also from timeline ([02ea464](02ea464)), closes [#86](#86)
* **scene:** Remove scene causes no error anymore ([96a152c](96a152c)), closes [#86](#86)
* **xy-pad:** Default values can be undefined ([a74da21](a74da21))
@TimPietrusky
Copy link
Member Author

🎉 This issue has been resolved in version 3.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
Next
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimPietrusky