Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove animation doesn't remove it from scene #85

Closed
TimPietrusky opened this issue Oct 4, 2018 · 2 comments
Closed

Remove animation doesn't remove it from scene #85

TimPietrusky opened this issue Oct 4, 2018 · 2 comments
Projects

Comments

@TimPietrusky
Copy link
Member

Issue description

When removing an animation that is part of a scene, the animation is not removed from the animation. Instead when removing the animation the following errors are thrown:

timeline-animation

    // Cannot read property 'keyframes' of undefined

    if (changedProperties.has('animation')) {
      this.timeline = this.computeTimeline(this.animation.keyframes);
    }

animation-list-item

// Cannot read property 'name' of undefined

    return html`
      <div>
        ${animation.name}
      </div>
    `;

Steps to reproduce

  • Add animation A
  • Add the animation A to scene A
  • Add scene A to the timeline
  • Remove animation A
  • Find animation A still assigned to scene A

Versions

  1. Browser: Chrome 69
  2. luminave: 3.0.0
@TimPietrusky TimPietrusky added this to To do in Next via automation Oct 4, 2018
@TimPietrusky TimPietrusky moved this from To do to In progress in Next Oct 9, 2019
@TimPietrusky TimPietrusky mentioned this issue Oct 10, 2019
Next automation moved this from In progress to Done Oct 10, 2019
TimPietrusky pushed a commit that referenced this issue Oct 10, 2019
# [3.6.0](v3.5.0...v3.6.0) (2019-10-10)

### Bug Fixes

* **animation:** Remove animation also from scene ([5ce15ca](5ce15ca)), closes [#85](#85)
* **directive:** Convert to new lit-html standard ([e099d31](e099d31))
* **dunarnia:** Updated channel for white and amber ([09c3256](09c3256))
* **jsconfbp:** Added one more channel ([0d760f9](0d760f9))

### Features

* **constant:** Added "amber" ([fdf73dc](fdf73dc))
* **jsconfbp:** Added all lights for the small stage @ akvarium ([e87142c](e87142c))
* **scene:** No animation for scene in timeline ([06f943c](06f943c))
* **scene:** No animation for scene in timeline ([e62d021](e62d021))
* **xy-pad:** Use the xy-pad to change Pan / Tilt ([1b6dd63](1b6dd63)), closes [#117](#117)
@TimPietrusky
Copy link
Member Author

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

TimPietrusky added a commit that referenced this issue Oct 11, 2019
When deleting an animation, it will also be deleted from related venues.

fix #85
@TimPietrusky TimPietrusky mentioned this issue Oct 11, 2019
TimPietrusky pushed a commit that referenced this issue Oct 11, 2019
## [3.6.1](v3.6.0...v3.6.1) (2019-10-11)

### Bug Fixes

* **animation:** Don't reset the scene when animation is done ([4866618](4866618)), closes [#112](#112)
* **animation:** Remove animation from venue ([950a21e](950a21e)), closes [#85](#85)
* **fixture:** Remove fixture from scene and venue ([5ce5d6f](5ce5d6f)), closes [#83](#83)
* **scene:** Remove scene also from timeline ([02ea464](02ea464)), closes [#86](#86)
* **scene:** Remove scene causes no error anymore ([96a152c](96a152c)), closes [#86](#86)
* **xy-pad:** Default values can be undefined ([a74da21](a74da21))
@TimPietrusky
Copy link
Member Author

🎉 This issue has been resolved in version 3.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Next
  
Done
Development

No branches or pull requests

1 participant