-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove animation doesn't remove it from scene #85
Comments
Merged
TimPietrusky
pushed a commit
that referenced
this issue
Oct 10, 2019
# [3.6.0](v3.5.0...v3.6.0) (2019-10-10) ### Bug Fixes * **animation:** Remove animation also from scene ([5ce15ca](5ce15ca)), closes [#85](#85) * **directive:** Convert to new lit-html standard ([e099d31](e099d31)) * **dunarnia:** Updated channel for white and amber ([09c3256](09c3256)) * **jsconfbp:** Added one more channel ([0d760f9](0d760f9)) ### Features * **constant:** Added "amber" ([fdf73dc](fdf73dc)) * **jsconfbp:** Added all lights for the small stage @ akvarium ([e87142c](e87142c)) * **scene:** No animation for scene in timeline ([06f943c](06f943c)) * **scene:** No animation for scene in timeline ([e62d021](e62d021)) * **xy-pad:** Use the xy-pad to change Pan / Tilt ([1b6dd63](1b6dd63)), closes [#117](#117)
🎉 This issue has been resolved in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TimPietrusky
added a commit
that referenced
this issue
Oct 11, 2019
When deleting an animation, it will also be deleted from related venues. fix #85
Merged
TimPietrusky
pushed a commit
that referenced
this issue
Oct 11, 2019
## [3.6.1](v3.6.0...v3.6.1) (2019-10-11) ### Bug Fixes * **animation:** Don't reset the scene when animation is done ([4866618](4866618)), closes [#112](#112) * **animation:** Remove animation from venue ([950a21e](950a21e)), closes [#85](#85) * **fixture:** Remove fixture from scene and venue ([5ce5d6f](5ce5d6f)), closes [#83](#83) * **scene:** Remove scene also from timeline ([02ea464](02ea464)), closes [#86](#86) * **scene:** Remove scene causes no error anymore ([96a152c](96a152c)), closes [#86](#86) * **xy-pad:** Default values can be undefined ([a74da21](a74da21))
🎉 This issue has been resolved in version 3.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
When removing an animation that is part of a scene, the animation is not removed from the animation. Instead when removing the animation the following errors are thrown:
timeline-animation
animation-list-item
Steps to reproduce
Versions
The text was updated successfully, but these errors were encountered: